lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 29 Apr 2024 08:23:46 -0700
From: Reinette Chatre <reinette.chatre@...el.com>
To: "Chen, Zide" <zide.chen@...el.com>, <isaku.yamahata@...el.com>,
	<pbonzini@...hat.com>, <erdemaktas@...gle.com>, <vkuznets@...hat.com>,
	<seanjc@...gle.com>, <vannapurve@...gle.com>, <jmattson@...gle.com>,
	<mlevitsk@...hat.com>, <xiaoyao.li@...el.com>, <chao.gao@...el.com>,
	<rick.p.edgecombe@...el.com>
CC: <kvm@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V5 4/4] KVM: selftests: Add test for configure of x86 APIC
 bus frequency

Hi Zide,

On 4/26/2024 10:38 PM, Chen, Zide wrote:
> On 4/26/2024 4:26 PM, Reinette Chatre wrote:
>> On 4/26/2024 4:06 PM, Chen, Zide wrote:
>>> On 4/25/2024 3:07 PM, Reinette Chatre wrote:
>>>> diff --git a/tools/testing/selftests/kvm/x86_64/apic_bus_clock_test.c b/tools/testing/selftests/kvm/x86_64/apic_bus_clock_test.c
>>>> new file mode 100644
>>>> index 000000000000..5100b28228af
>>>> --- /dev/null
>>>> +++ b/tools/testing/selftests/kvm/x86_64/apic_bus_clock_test.c
>>>> @@ -0,0 +1,166 @@
>>>> +// SPDX-License-Identifier: GPL-2.0-only
>>>> +/*
>>>> + * Test configure of APIC bus frequency.
>>>> + *
>>>> + * Copyright (c) 2024 Intel Corporation
>>>> + *
>>>> + * To verify if the APIC bus frequency can be configured this test starts
>>>
>>> Nit: some typos here?
>>
>> Apologies but this is not obvious to me. Could you please help
>> by pointing out all those typos to me?
> 
> Do you think it's more readable to add a ","?
> 
> - * To verify if the APIC bus frequency can be configured this test starts
> + * To verify if the APIC bus frequency can be configured, this test starts
>   * by setting the TSC frequency in KVM, and then:

Sure. I'll do so in the next version.

Thank you.

Reinette

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ