linux-kernel - Re: [PATCH v7 4/6] dt-bindings: iio: adc: Add single-channel property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240430-perplexed-obedience-91e4bbc158e5@spud>
Date: Tue, 30 Apr 2024 18:15:31 +0100
From: Conor Dooley <conor@...nel.org>
To: Alisa-Dariana Roman <alisadariana@...il.com>
Cc: michael.hennerich@...log.com, linux-iio@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	alexandru.tachici@...log.com, lars@...afoo.de, jic23@...nel.org,
	robh@...nel.org, krzysztof.kozlowski+dt@...aro.org,
	conor+dt@...nel.org, lgirdwood@...il.com, broonie@...nel.org,
	andy@...nel.org, nuno.sa@...log.com, marcelo.schmitt@...log.com,
	bigunclemax@...il.com, dlechner@...libre.com, okan.sahin@...log.com,
	fr0st61te@...il.com, alisa.roman@...log.com,
	marcus.folkesson@...il.com, schnelle@...ux.ibm.com,
	liambeguin@...il.com
Subject: Re: [PATCH v7 4/6] dt-bindings: iio: adc: Add single-channel property

On Tue, Apr 30, 2024 at 07:29:44PM +0300, Alisa-Dariana Roman wrote:
> Devices that have both single-ended channels and differential channels
> cause a bit of confusion when the channels are configured in the
> devicetree.
> 
> Clarify difference between these two types of channels for such devices
> by adding single-channel property alongside diff-channels. They should
> be mutually exclusive.

I think that this mutual exclusion and the requirement for reg in the
absence of either property should be enforced by the binding, not
described in a commit message or free-form text in the property
description.

> 
> Devices that have only single-ended channels can still use reg property
> to reference a channel like before.
> 
> Suggested-by: Jonathan Cameron <jic23@...nel.org>
> Signed-off-by: Alisa-Dariana Roman <alisa.roman@...log.com>
> ---
>  Documentation/devicetree/bindings/iio/adc/adc.yaml | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/adc.yaml b/Documentation/devicetree/bindings/iio/adc/adc.yaml
> index 36775f8f71df..0c3eae580732 100644
> --- a/Documentation/devicetree/bindings/iio/adc/adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/adc.yaml
> @@ -38,6 +38,14 @@ properties:
>        The first value specifies the positive input pin, the second
>        specifies the negative input pin.
>  
> +  single-channel:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description:

> +      When devices combine single

s/single/single-ended/, no?

Cheers,
Conor.

> and differential channels, allow the channel
> +      for a single element to be specified, independent of reg (as for
> +      differential channels). If this and diff-channels are not present reg
> +      shall be used instead.
> +
>    settling-time-us:
>      description:
>        Time between enabling the channel and first stable readings.
> -- 
> 2.34.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)