linux-kernel - Re: [PATCH 2/2] media: bcm2835-unicam: Include v4l2-subdev.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240501114715.GG17852@pendragon.ideasonboard.com>
Date: Wed, 1 May 2024 14:47:15 +0300
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
Cc: linux-media@...r.kernel.org,
	Florian Fainelli <florian.fainelli@...adcom.com>,
	Ray Jui <rjui@...adcom.com>, Scott Branden <sbranden@...adcom.com>,
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>,
	Naushir Patuck <naush@...pberrypi.com>,
	Dave Stevenson <dave.stevenson@...pberrypi.com>,
	Sakari Ailus <sakari.ailus@...ux.intel.com>,
	linux-rpi-kernel@...ts.infradead.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] media: bcm2835-unicam: Include v4l2-subdev.h

Hi Ricardo,

On Wed, May 01, 2024 at 01:07:29PM +0200, Ricardo Ribalda Delgado wrote:
> Hi Laurent
> 
> I have to send a v2 of
> https://patchwork.linuxtv.org/project/linux-media/list/?series=12759 I
> can include this patch in that set if you want

Fine with me.

> On Tue, Apr 30, 2024 at 11:39 PM Laurent Pinchart wrote:
> >
> > The unicam driver uses the v4l2_subdev structure. Include the
> > corresponding header instead of relying on indirect includes.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> > Reported-by: kernel test robot <lkp@...el.com>
> Reviewed-by: Ricardo Ribalda <ribalda@...omium.org>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202404302324.8aTC84kE-lkp@intel.com/
> > ---
> >  drivers/media/platform/broadcom/bcm2835-unicam.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/media/platform/broadcom/bcm2835-unicam.c b/drivers/media/platform/broadcom/bcm2835-unicam.c
> > index c590e26fe2cf..3c7878d8d79b 100644
> > --- a/drivers/media/platform/broadcom/bcm2835-unicam.c
> > +++ b/drivers/media/platform/broadcom/bcm2835-unicam.c
> > @@ -55,6 +55,7 @@
> >  #include <media/v4l2-ioctl.h>
> >  #include <media/v4l2-fwnode.h>
> >  #include <media/v4l2-mc.h>
> > +#include <media/v4l2-subdev.h>
> >  #include <media/videobuf2-dma-contig.h>
> >
> >  #include "bcm2835-unicam-regs.h"

-- 
Regards,

Laurent Pinchart