linux-kernel - Re: [PATCH v2 2/3] iio: pressure: Add driver for Sensirion SDP500

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADFWO8HL_pwEQwYn0K9AkPV=HZyWN3NSOs8k4dRrB40w_1KdCw@mail.gmail.com>
Date: Wed, 1 May 2024 13:48:24 +0200
From: Petar Stoykov <pd.pstoykov@...il.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: linux-iio@...r.kernel.org, Jonathan Cameron <jic23@...nel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Lars-Peter Clausen <lars@...afoo.de>, 
	Rob Herring <robh+dt@...nel.org>, Angel Iglesias <ang.iglesiasg@...il.com>, 
	Conor Dooley <conor+dt@...nel.org>, linux-kernel@...r.kernel.org, 
	devicetree@...r.kernel.org
Subject: Re: [PATCH v2 2/3] iio: pressure: Add driver for Sensirion SDP500

On Tue, Apr 30, 2024 at 5:40 PM Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
>
> On Tue, Apr 30, 2024 at 05:27:24PM +0200, Petar Stoykov wrote:
> > From 6ae7537517f551540121ca6fb3b99080b7580410 Mon Sep 17 00:00:00 2001
> > From: Petar Stoykov <pd.pstoykov@...il.com>
> > Date: Mon, 15 Jan 2024 12:21:26 +0100
> > Subject: [PATCH 2/3] iio: pressure: Add driver for Sensirion SDP500
> >
> > Sensirion SDP500 is a digital differential pressure sensor. The sensor is
> > accessed over I2C.
>
> Any Datasheet: tag can be added?
>

Ok. I see some drivers also include the pdf link in the driver's code.
I can do that as well.

> ...
>
> > +config SDP500
> > +    tristate "Sensirion SDP500 differential pressure sensor I2C driver"
> > +    depends on I2C
> > +    help
> > +      Say Y here to build support for Sensirion SDP500 differential pressure
> > +      sensor I2C driver.
> > +      To compile this driver as a module, choose M here: the core module
> > +      will be called sdp500.
>
> You patch is broken. Fix the way how you send patches.
>
> ...
>
> > +static int sdp500_start_measurement(struct sdp500_data *data, const
> > struct iio_dev *indio_dev)
>
> Here is more visible.
>
> --
> With Best Regards,
> Andy Shevchenko
>
>

I finally figured it out. Gmail has a hard word-wrap at 80 characters per line.
At first I thought it was word-wrap on the receiving side but I was wrong.
I will try to convince IT to change things so I can use b4 or git send e-mail.
If that doesn't work then I guess my code will have shorter lines in next patch.