linux-kernel - Re: [PATCH v4 1/3] usb: gadget: function: move u

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 1 May 2024 10:19:18 -0400
From: Alan Stern <stern@...land.harvard.edu>
To: Michael Grzeschik <mgr@...gutronix.de>
Cc: Eric Van Hensbergen <ericvh@...nel.org>,
  Latchesar Ionkov <lucho@...kov.net>,
  Dominique Martinet <asmadeus@...ewreck.org>,
  Christian Schoenebeck <linux_oss@...debyte.com>,
  Jonathan Corbet <corbet@....net>,
  Greg Kroah-Hartman <gregkh@...uxfoundation.org>, v9fs@...ts.linux.dev,
  linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
  linux-usb@...r.kernel.org, kernel@...gutronix.de
Subject: Re: [PATCH v4 1/3] usb: gadget: function: move u_f.h to
 include/linux/usb/

On Wed, May 01, 2024 at 10:38:11AM +0200, Michael Grzeschik wrote:
> On Mon, Apr 29, 2024 at 09:51:20PM -0400, Alan Stern wrote:
> > On Tue, Apr 30, 2024 at 01:33:26AM +0200, Michael Grzeschik wrote:
> > > We move the u_f.h header to include/linux/usb to be
> > > able to compile function drivers outside of the
> > > drivers/usb/gadget/function directory.
> > > 
> > > Signed-off-by: Michael Grzeschik <m.grzeschik@...gutronix.de>
> > 
> > Given that you're moving a private header file to a public location,
> > don't you think it should now have a name that's more meaningful to
> > general kernel developers than "u_f.h"?
> 
> Fair point.
> 
> How about func_utils.h instead?

Yes, that would be a lot better.  Especially if you put it in 
include/linux/usb/gadget rather than include/linux/usb.

Thanks.

Alan Stern