linux-kernel - Re: [PATCH] backlight: sky81452-backlight: replace of_node_put with _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 1 May 2024 16:19:42 +0200 (CEST)
From: Julia Lawall <julia.lawall@...ia.fr>
To: Daniel Thompson <daniel.thompson@...aro.org>
cc: R Sundar <prosunofficial@...il.com>, Lee Jones <lee@...nel.org>, 
    Jingoo Han <jingoohan1@...il.com>, Helge Deller <deller@....de>, 
    dri-devel@...ts.freedesktop.org, linux-fbdev@...r.kernel.org, 
    linux-kernel@...r.kernel.org, skhan@...uxfoundation.org, 
    javier.carrasco.cruz@...il.com, Julia Lawall <julia.lawall@...ia.fr>, 
    Shresth Prasad <shresthprasad7@...il.com>
Subject: Re: [PATCH] backlight: sky81452-backlight: replace of_node_put with
 __free



On Wed, 1 May 2024, Daniel Thompson wrote:

> On Wed, May 01, 2024 at 06:21:46PM +0530, R Sundar wrote:
> > Use the new cleanup magic to replace of_node_put() with
> > __free(device_node) marking to auto release when they get out of scope.
> >
> > Suggested-by: Julia Lawall <julia.lawall@...ia.fr>
> > Signed-off-by: R Sundar <prosunofficial@...il.com>
>
> Thanks for the patch but I think this one is a more appropriate
> solution to this issue:
> https://lore.kernel.org/all/20240421104916.312588-2-shresthprasad7@gmail.com/

Maybe neither one is perfect?  The one I see at that link has:

 	if (!pdata) {
-		of_node_put(np);
 		return ERR_PTR(-ENOMEM);
 	}

which has unneeded {}

julia


>
>
> Daniel.
>