[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZjJ0P2d5v5fW5J7h@slm.duckdns.org>
Date: Wed, 1 May 2024 06:56:31 -1000
From: Tejun Heo <tj@...nel.org>
To: Kemeng Shi <shikemeng@...weicloud.com>
Cc: willy@...radead.org, akpm@...ux-foundation.org, jack@...e.cz,
linux-fsdevel@...r.kernel.org, linux-mm@...ck.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 04/10] writeback use [global/wb]_domain_dirty_avail
helper in cgwb_calc_thresh
Hello,
On Mon, Apr 29, 2024 at 11:47:32AM +0800, Kemeng Shi wrote:
> Use [global/wb]_domain_dirty_avail helper in cgwb_calc_thresh to remove
> repeated code.
Maybe fold this into the patch to factor out domain_dirty_avail()?
> + global_domain_dirty_avail(&gdtc, false);
> + wb_domain_dirty_avail(&mdtc, false);
I'd just use domain_dirty_avail(). The compiler should be able to figure out
the branches and eliminate them and it removes an unnecessary source of
error.
Thanks.
--
tejun
Powered by blists - more mailing lists