linux-kernel - Re: [PATCH] PCI/ASPM: Clarify that pcie

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e84ba9a250615de2f39600160ad0577f2d5caf94.camel@linux.intel.com>
Date: Wed, 01 May 2024 13:07:01 -0700
From: "David E. Box" <david.e.box@...ux.intel.com>
To: Bjorn Helgaas <helgaas@...nel.org>, linux-pci@...r.kernel.org
Cc: Vidya Sagar <vidyas@...dia.com>, Ilpo Järvinen
 <ilpo.jarvinen@...ux.intel.com>, "Maciej W . Rozycki" <macro@...am.me.uk>, 
 Johan Hovold <johan+linaro@...nel.org>, Heiner Kallweit
 <hkallweit1@...il.com>, Ajay Agarwal <ajayagarwal@...gle.com>,
 linux-kernel@...r.kernel.org, Bjorn Helgaas <bhelgaas@...gle.com>
Subject: Re: [PATCH] PCI/ASPM: Clarify that pcie_aspm=off means leave ASPM
 untouched

On Mon, 2024-04-29 at 14:18 -0500, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@...gle.com>
> 
> Previously we claimed "pcie_aspm=off" meant that ASPM would be disabled,
> which is wrong.
> 
> Correct this to say that with "pcie_aspm=off", Linux doesn't touch any ASPM
> configuration at all.  ASPM may have been enabled by firmware, and that
> will be left unchanged.  See "aspm_support_enabled".
> 
> Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com>

LGTM.

Reviewed-by: David E. Box <david.e.box@...ux.intel.com>

> ---
>  Documentation/admin-guide/kernel-parameters.txt | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/admin-guide/kernel-parameters.txt
> b/Documentation/admin-guide/kernel-parameters.txt
> index bb884c14b2f6..4bc281d6e8d3 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -4590,9 +4590,10 @@
>                 norid           [S390] ignore the RID field and force use of
>                                 one PCI domain per PCI function
>  
> -       pcie_aspm=      [PCIE] Forcibly enable or disable PCIe Active State
> Power
> +       pcie_aspm=      [PCIE] Forcibly enable or ignore PCIe Active State
> Power
>                         Management.
> -               off     Disable ASPM.
> +               off     Don't touch ASPM configuration at all.  Leave any
> +                       configuration done by firmware unchanged.
>                 force   Enable ASPM even on devices that claim not to support
> it.
>                         WARNING: Forcing ASPM on may cause system lockups.
>