linux-kernel - Re: [PATCH] spmi: pmic-arb: Fix of_irq_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dba8658a-f13f-4fde-b610-57a391b0a1c2@moroto.mountain>
Date: Thu, 2 May 2024 10:08:29 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Stephen Boyd <sboyd@...nel.org>
Cc: Abel Vesa <abel.vesa@...aro.org>,
	Neil Armstrong <neil.armstrong@...aro.org>,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] spmi: pmic-arb: Fix of_irq_get_byname() error checking

On Wed, May 01, 2024 at 05:55:03PM -0700, Stephen Boyd wrote:
> Quoting Dan Carpenter (2024-04-24 04:42:46)
> > There are two bugs in this code:
> > 1)  The "irq" variable needs to be signed for the error handling to
> >     work.
> > 2) The of_irq_get_byname() also returns zero on error so change the
> >    comparison from < 0 to <= 0.
> > 
> > Fixes: 932282f154ac ("spmi: pmic-arb: Register controller for bus instead of arbiter")
> 
> Sadly this isn't stable because I just send patches over email.
> 

If you're going to send these as email then you should fold it into the
original commit or otherwise people will be confused.

> > Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> > ---
> 
> Applied to spmi-next

Thanks!

regards,
dan carpenter