[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <0d26a80d9b595954aabd8f6c6e18c710.sboyd@kernel.org>
Date: Wed, 01 May 2024 17:55:03 -0700
From: Stephen Boyd <sboyd@...nel.org>
To: Abel Vesa <abel.vesa@...aro.org>, Dan Carpenter <dan.carpenter@...aro.org>
Cc: Neil Armstrong <neil.armstrong@...aro.org>, linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] spmi: pmic-arb: Fix of_irq_get_byname() error checking
Quoting Dan Carpenter (2024-04-24 04:42:46)
> There are two bugs in this code:
> 1) The "irq" variable needs to be signed for the error handling to
> work.
> 2) The of_irq_get_byname() also returns zero on error so change the
> comparison from < 0 to <= 0.
>
> Fixes: 932282f154ac ("spmi: pmic-arb: Register controller for bus instead of arbiter")
Sadly this isn't stable because I just send patches over email.
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
Applied to spmi-next
Powered by blists - more mailing lists