linux-kernel - Re: [PATCH 3/4] soc: imx: secvio: Add support for SNVS secvio and tamper via SCFW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 2 May 2024 08:54:44 +0800
From: kernel test robot <lkp@...el.com>
To: Vabhav Sharma <vabhav.sharma@....com>, Rob Herring <robh+dt@...nel.org>,
	Krzysztof Kozlowski <krzk@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>, linux-imx@....com,
	Ulf Hansson <ulf.hansson@...aro.org>, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Iuliana Prodan <iuliana.prodan@....com>
Cc: oe-kbuild-all@...ts.linux.dev,
	Silvano Di Ninno <silvano.dininno@....com>,
	Varun Sethi <V.Sethi@....com>, Pankaj Gupta <pankaj.gupta@....com>,
	Peng Fan <peng.fan@....com>, Dong Aisheng <aisheng.dong@....com>,
	frank.li@....com, daniel.baluta@....com,
	Vabhav Sharma <vabhav.sharma@....com>,
	Franck LENORMAND <franck.lenormand@....com>
Subject: Re: [PATCH 3/4] soc: imx: secvio: Add support for SNVS secvio and
 tamper via SCFW

Hi Vabhav,

kernel test robot noticed the following build warnings:

[auto build test WARNING on shawnguo/for-next]
[also build test WARNING on robh/for-next krzk/for-next krzk-dt/for-next linus/master v6.9-rc6 next-20240501]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Vabhav-Sharma/dt-bindings-firmware-secvio-Add-documentation/20240501-133607
base:   https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git for-next
patch link:    https://lore.kernel.org/r/20240501053205.1737248-4-vabhav.sharma%40nxp.com
patch subject: [PATCH 3/4] soc: imx: secvio: Add support for SNVS secvio and tamper via SCFW
config: hexagon-randconfig-r131-20240502 (https://download.01.org/0day-ci/archive/20240502/202405020818.2mTfooXt-lkp@intel.com/config)
compiler: clang version 19.0.0git (https://github.com/llvm/llvm-project 37ae4ad0eef338776c7e2cffb3896153d43dcd90)
reproduce: (https://download.01.org/0day-ci/archive/20240502/202405020818.2mTfooXt-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405020818.2mTfooXt-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
>> drivers/soc/imx/secvio/imx-secvio-sc.c:381:37: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected void [noderef] __user *to @@     got void * @@
   drivers/soc/imx/secvio/imx-secvio-sc.c:381:37: sparse:     expected void [noderef] __user *to
   drivers/soc/imx/secvio/imx-secvio-sc.c:381:37: sparse:     got void *
>> drivers/soc/imx/secvio/imx-secvio-sc.c:393:46: sparse: sparse: incorrect type in argument 2 (different address spaces) @@     expected void const [noderef] __user *from @@     got void * @@
   drivers/soc/imx/secvio/imx-secvio-sc.c:393:46: sparse:     expected void const [noderef] __user *from
   drivers/soc/imx/secvio/imx-secvio-sc.c:393:46: sparse:     got void *

vim +381 drivers/soc/imx/secvio/imx-secvio-sc.c

   368	
   369	static long imx_secvio_sc_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
   370	{
   371		struct device *dev = file->private_data;
   372		struct secvio_sc_notifier_info info;
   373		int ret;
   374	
   375		switch (cmd) {
   376		case IMX_SECVIO_SC_GET_STATE:
   377			ret = imx_secvio_sc_get_state(dev, &info);
   378			if (ret)
   379				return ret;
   380	
 > 381			ret = copy_to_user((void *)arg, &info, sizeof(info));
   382			if (ret) {
   383				dev_err(dev, "Fail to copy info to user\n");
   384				return -EFAULT;
   385			}
   386			break;
   387		case IMX_SECVIO_SC_CHECK_STATE:
   388			ret = imx_secvio_sc_check_state(dev);
   389			if (ret)
   390				return ret;
   391			break;
   392		case IMX_SECVIO_SC_CLEAR_STATE:
 > 393			ret = copy_from_user(&info, (void *)arg, sizeof(info));
   394			if (ret) {
   395				dev_err(dev, "Fail to copy info from user\n");
   396				return -EFAULT;
   397			}
   398	
   399			ret = imx_secvio_sc_clear_state(dev, info.hpsvs, info.lps,
   400							    info.lptds);
   401			if (ret)
   402				return ret;
   403			break;
   404		default:
   405			ret = -ENOIOCTLCMD;
   406		}
   407	
   408		return ret;
   409	}
   410	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki