linux-kernel - RE: [EXT] Re: [PATCH 1/4] dt-bindings: firmware: secvio: Add documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 9 May 2024 04:04:29 +0000
From: Vabhav Sharma <vabhav.sharma@....com>
To: Krzysztof Kozlowski <krzk@...nel.org>, Rob Herring <robh+dt@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley
	<conor+dt@...nel.org>, Pengutronix Kernel Team <kernel@...gutronix.de>, Fabio
 Estevam <festevam@...il.com>, dl-linux-imx <linux-imx@....com>, Ulf Hansson
	<ulf.hansson@...aro.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>, Iuliana Prodan
	<iuliana.prodan@....com>
CC: Silvano Di Ninno <silvano.dininno@....com>, Varun Sethi <V.Sethi@....com>,
	Pankaj Gupta <pankaj.gupta@....com>, Peng Fan <peng.fan@....com>, Aisheng
 Dong <aisheng.dong@....com>, Frank Li <frank.li@....com>, Daniel Baluta
	<daniel.baluta@....com>, Franck Lenormand <franck.lenormand@....com>
Subject: RE: [EXT] Re: [PATCH 1/4] dt-bindings: firmware: secvio: Add
 documentation



> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@...nel.org>
> Sent: Wednesday, May 1, 2024 3:16 PM
> To: Vabhav Sharma <vabhav.sharma@....com>; Rob Herring
> <robh+dt@...nel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@...aro.org>; Conor Dooley <conor+dt@...nel.org>;
> Pengutronix Kernel Team <kernel@...gutronix.de>; Fabio Estevam
> <festevam@...il.com>; dl-linux-imx <linux-imx@....com>; Ulf Hansson
> <ulf.hansson@...aro.org>; linux-kernel@...r.kernel.org; linux-arm-
> kernel@...ts.infradead.org; Shawn Guo <shawnguo@...nel.org>; Sascha
> Hauer <s.hauer@...gutronix.de>; Iuliana Prodan
> <iuliana.prodan@....com>
> Cc: Silvano Di Ninno <silvano.dininno@....com>; Varun Sethi
> <V.Sethi@....com>; Pankaj Gupta <pankaj.gupta@....com>; Peng Fan
> <peng.fan@....com>; Aisheng Dong <aisheng.dong@....com>; Frank Li
> <frank.li@....com>; Daniel Baluta <daniel.baluta@....com>; Franck
> Lenormand <franck.lenormand@....com>
> Subject: [EXT] Re: [PATCH 1/4] dt-bindings: firmware: secvio: Add
> documentation
>
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
>
>
> On 01/05/2024 07:32, Vabhav Sharma wrote:
> > This patch adds the documentation for the SECVIO driver.
>
> Please do not use "This commit/patch/change", but imperative mood. See
> longer explanation here:
> https://elixir.b/
> ootlin.com%2Flinux%2Fv5.17.1%2Fsource%2FDocumentation%2Fprocess%2F
> submitting-
> patches.rst%23L95&data=05%7C02%7Cvabhav.sharma%40nxp.com%7C4e698
> f57f2be4e4b419c08dc69c39540%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C
> 0%7C0%7C638501535958415388%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiM
> C4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C
> %7C%7C&sdata=7NB%2FbjnqJStL2QBVTwGflgSSViD9n8TL78X85OtQX54%3D&
> reserved=0
>
> Describe hardware, not driver.
Ok
>
>
> >
> > Signed-off-by: Franck LENORMAND <franck.lenormand@....com>
> > Signed-off-by: Vabhav Sharma <vabhav.sharma@....com>
>
>
> Please use scripts/get_maintainers.pl to get a list of necessary people and lists
> to CC. It might happen, that command when run on an older kernel, gives you
> outdated entries. Therefore please be sure you base your patches on recent
> Linux kernel.
>
> Tools like b4 or scripts/get_maintainer.pl provide you proper list of people, so
> fix your workflow. Tools might also fail if you work on some ancient tree
> (don't, instead use mainline), work on fork of kernel (don't, instead use
> mainline) or you ignore some maintainers (really don't). Just use b4 and
> everything should be fine, although remember about `b4 prep --auto-to-cc` if
> you added new patches to the patchset.
Thank you for feedback and used b4 as recommended
>
> You missed at least devicetree list (maybe more), so this won't be tested by
> automated tooling. Performing review on untested code might be a waste of
> time, thus I will skip this patch entirely till you follow the process allowing the
> patch to be tested.
Added the required list
>
> Please kindly resend and include all necessary To/Cc entries.
Ok, done
>
>
> Best regards,
> Krzysztof