linux-kernel - Re: [PATCH] mfd: axp20x: convert to use maple tree register cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240502093316.GI5338@google.com>
Date: Thu, 2 May 2024 10:33:16 +0100
From: Lee Jones <lee@...nel.org>
To: Markus Elfring <Markus.Elfring@....de>
Cc: wangkaiyuan@...pur.com, kernel-janitors@...r.kernel.org,
	Chen-Yu Tsai <wens@...e.org>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mfd: axp20x: convert to use maple tree register cache

On Mon, 29 Apr 2024, Markus Elfring wrote:

> > The maple tree register cache is based on a much more modern data structure
> > than the rbtree cache and makes optimisation choices which are probably
> > more appropriate for modern systems than those made by the rbtree cache.
> 
> Please choose another imperative wording for an improved change description.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9-rc5#n94

This review comment is seldom helpful.

You may as well stop using it.

-- 
Lee Jones [李琼斯]