linux-kernel - Re: [PATCH v3][next] backlight: sky81452-backlight: Remove unnecessary call to of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE8VWiLP-QR_KaHBPYjA=UVJ8SShpKseB5Xp9Hpkd1RMcvt-qw@mail.gmail.com>
Date: Thu, 2 May 2024 15:30:02 +0530
From: Shresth Prasad <shresthprasad7@...il.com>
To: Lee Jones <lee@...nel.org>
Cc: daniel.thompson@...aro.org, jingoohan1@...il.com, deller@....de, 
	dri-devel@...ts.freedesktop.org, linux-fbdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org, javier.carrasco.cruz@...il.com, 
	skhan@...uxfoundation.org, julia.lawall@...ia.fr
Subject: Re: [PATCH v3][next] backlight: sky81452-backlight: Remove
 unnecessary call to of_node_get

On Thu, May 2, 2024 at 3:06 PM Lee Jones <lee@...nel.org> wrote:
>
> On Thu, 02 May 2024, Shresth Prasad wrote:
>
> > `dev->of_node` already has a reference to the device_node and calling
> > of_node_get on it is unnecessary. All conresponding calls to
> > of_node_put are also removed.
> >
> > Reviewed-by: Daniel Thompson <daniel.thompson@...aro.org>
> > Signed-off-by: Shresth Prasad <shresthprasad7@...il.com>
> > ---
> > Changes in v3:
> >     - Remove unnecessary braces
> >
> >  drivers/video/backlight/sky81452-backlight.c | 8 ++------
> >  1 file changed, 2 insertions(+), 6 deletions(-)
>
> No idea what you're talking about.
>
> This patch/version doesn't exist in either my inbox or LORE:
>
>   https://lore.kernel.org/all/?q=%22%5BPATCH+v3%5D%5Bnext%5D+backlight%3A+sky81452-backlight%3A+Remove+unnecessary+call+to+of_node_get%22
>
> --
> Lee Jones [李琼斯]

I'm not sure what you mean.
The patches show up just fine:
https://lore.kernel.org/all/?q=backlight%3A+sky81452-backlight%3A+Remove+unnecessary+call+to+of_node_get

If you mean that the first version doesn't show up, it's because the
commit message
was changed to better reflect changes.

Regards,
Shresth