[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240502101145.GT5338@google.com>
Date: Thu, 2 May 2024 11:11:45 +0100
From: Lee Jones <lee@...nel.org>
To: Jarkko Nikula <jarkko.nikula@...ux.intel.com>
Cc: Andi Shyti <andi.shyti@...nel.org>,
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
Florian Fainelli <florian.fainelli@...adcom.com>,
linux-kernel@...r.kernel.org,
Mika Westerberg <mika.westerberg@...ux.intel.com>,
Jan Dabros <jsd@...ihalf.com>, Jiawen Wu <jiawenwu@...stnetic.com>,
Mengyuan Lou <mengyuanlou@...-swift.com>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Maciej Fijalkowski <maciej.fijalkowski@...el.com>,
Andrew Lunn <andrew@...n.ch>,
Duanqiang Wen <duanqiangwen@...-swift.com>,
"open list:SYNOPSYS DESIGNWARE I2C DRIVER" <linux-i2c@...r.kernel.org>,
"open list:WANGXUN ETHERNET DRIVER" <netdev@...r.kernel.org>
Subject: Re: [PATCH v3 4/5] mfd: intel_quark_i2c_gpio: Utilize
i2c-designware.h
On Thu, 02 May 2024, Jarkko Nikula wrote:
> On 4/30/24 12:36 PM, Andi Shyti wrote:
> > Hi Andy,
> >
> > On Fri, Apr 26, 2024 at 05:30:24PM +0300, Andy Shevchenko wrote:
> > > On Thu, Apr 25, 2024 at 02:44:37PM -0700, Florian Fainelli wrote:
> > > > Rather than open code the i2c_designware string, utilize the newly
> > > > defined constant in i2c-designware.h.
> > >
> > > Acked-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > >
> > > P.S>
> > > Note, my tags for MFD patches does not imply that I agree on the general idea
> > > of this series, it's just in case if it will be approved by the respective
> > > maintainers (I²C / MFD / etc).
> >
> > I waited a bit to see if more comments were coming.
> >
> Well I had doubts about the idea will it help maintaining code or do the
> opposite but didn't receive a reply from the patch author:
>
> https://lore.kernel.org/linux-i2c/62e58960-f568-459d-8690-0c9c608a4d9f@linux.intel.com/
>
> Also Lee Jones have similar concerns:
>
> https://lore.kernel.org/linux-i2c/20240502071751.GA5338@google.com/
Right. It's a NACK from me, sorry.
--
Lee Jones [李琼斯]
Powered by blists - more mailing lists