linux-kernel - Re: [PATCH v3 4/5] mfd: intel_quark_i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f632fcd8-bcad-439f-a5ad-f498d98d357d@broadcom.com>
Date: Thu, 2 May 2024 09:08:31 -0700
From: Florian Fainelli <florian.fainelli@...adcom.com>
To: Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
 Andi Shyti <andi.shyti@...nel.org>,
 Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: linux-kernel@...r.kernel.org,
 Mika Westerberg <mika.westerberg@...ux.intel.com>,
 Jan Dabros <jsd@...ihalf.com>, Lee Jones <lee@...nel.org>,
 Jiawen Wu <jiawenwu@...stnetic.com>, Mengyuan Lou
 <mengyuanlou@...-swift.com>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>,
 Maciej Fijalkowski <maciej.fijalkowski@...el.com>,
 Andrew Lunn <andrew@...n.ch>, Duanqiang Wen <duanqiangwen@...-swift.com>,
 "open list:SYNOPSYS DESIGNWARE I2C DRIVER" <linux-i2c@...r.kernel.org>,
 "open list:WANGXUN ETHERNET DRIVER" <netdev@...r.kernel.org>
Subject: Re: [PATCH v3 4/5] mfd: intel_quark_i2c_gpio: Utilize
 i2c-designware.h

On 5/2/24 02:19, Jarkko Nikula wrote:
> On 4/30/24 12:36 PM, Andi Shyti wrote:
>> Hi Andy,
>>
>> On Fri, Apr 26, 2024 at 05:30:24PM +0300, Andy Shevchenko wrote:
>>> On Thu, Apr 25, 2024 at 02:44:37PM -0700, Florian Fainelli wrote:
>>>> Rather than open code the i2c_designware string, utilize the newly
>>>> defined constant in i2c-designware.h.
>>>
>>> Acked-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
>>>
>>> P.S>
>>> Note, my tags for MFD patches does not imply that I agree on the 
>>> general idea
>>> of this series, it's just in case if it will be approved by the 
>>> respective
>>> maintainers (I²C / MFD / etc).
>>
>> I waited a bit to see if more comments were coming.
>>
> Well I had doubts about the idea will it help maintaining code or do the 
> opposite but didn't receive a reply from the patch author:
> 
> https://lore.kernel.org/linux-i2c/62e58960-f568-459d-8690-0c9c608a4d9f@linux.intel.com/

I read your message and the fact that you provided a diff as a 
suggestion as to what would become acceptable if incorporating your 
suggested change, and made that a v3. If this was not acceptable to you 
from the get go, it would have been clearer with an explicit Nack like 
what others have done now.

> 
> Also Lee Jones have similar concerns:
> 
> https://lore.kernel.org/linux-i2c/20240502071751.GA5338@google.com/
> 

Yes, so clearly I failed to convince all of you that if someone was able 
to trip over that problem, something should be done about it. No 
problem, these are not driver I maintain, so if someone hits the same 
issue, lore has the patches now.
-- 
Florian

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4221 bytes)