linux-kernel - Re: [PATCH net-next v2] net/mlx5e: flower: check for unsupported control flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 02 May 2024 13:30:26 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Tariq Toukan <ttoukan.linux@...il.com>, Asbjørn
	Sloth Tønnesen
	 <ast@...erby.net>, netdev@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, 
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Saeed
 Mahameed <saeedm@...dia.com>,  Tariq Toukan <tariqt@...dia.com>, Leon
 Romanovsky <leon@...nel.org>, Jianbo Liu <jianbol@...dia.com>
Subject: Re: [PATCH net-next v2] net/mlx5e: flower: check for unsupported
 control flags

On Tue, 2024-04-30 at 08:15 +0300, Tariq Toukan wrote:
> 
> On 22/04/2024 18:27, Asbjørn Sloth Tønnesen wrote:
> > Use flow_rule_is_supp_control_flags() to reject filters
> > with unsupported control flags.
> > 
> > In case any unsupported control flags are masked,
> > flow_rule_is_supp_control_flags() sets a NL extended
> > error message, and we return -EOPNOTSUPP.
> > 
> > Remove FLOW_DIS_FIRST_FRAG specific error message,
> > and treat it as any other unsupported control flag.
> > 
> > Only compile-tested.
> > 
> > Signed-off-by: Asbjørn Sloth Tønnesen <ast@...erby.net>
> > ---
> > 
> > Changelog:
> > 
> > v2:
> > - remove existing FLOW_DIS_FIRST_FRAG "support" (requested by Jianbo)
> > 
> > v1: https://lore.kernel.org/netdev/20240417135110.99900-1-ast@fiberby.net/
> > 
> >   drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 10 ++++------
> >   1 file changed, 4 insertions(+), 6 deletions(-)
> > 
> > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> > index aeb32cb27182..30673292e15f 100644
> > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> > @@ -2801,12 +2801,6 @@ static int __parse_cls_flower(struct mlx5e_priv *priv,
> >   		flow_rule_match_control(rule, &match);
> >   		addr_type = match.key->addr_type;
> >   
> > -		/* the HW doesn't support frag first/later */
> > -		if (match.mask->flags & FLOW_DIS_FIRST_FRAG) {
> > -			NL_SET_ERR_MSG_MOD(extack, "Match on frag first/later is not supported");
> > -			return -EOPNOTSUPP;
> > -		}
> > -
> >   		if (match.mask->flags & FLOW_DIS_IS_FRAGMENT) {
> >   			MLX5_SET(fte_match_set_lyr_2_4, headers_c, frag, 1);
> >   			MLX5_SET(fte_match_set_lyr_2_4, headers_v, frag,
> > @@ -2819,6 +2813,10 @@ static int __parse_cls_flower(struct mlx5e_priv *priv,
> >   			else
> >   				*match_level = MLX5_MATCH_L3;
> >   		}
> > +
> > +		if (!flow_rule_is_supp_control_flags(FLOW_DIS_IS_FRAGMENT,
> > +						     match.mask->flags, extack))
> > +			return -EOPNOTSUPP;
> >   	}
> >   
> >   	if (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_BASIC)) {
> 
> Acked-by: Tariq Toukan <tariqt@...dia.com>

@Tariq/@...ed: do you want to take this patch towards your tree and
send or do you prefer we merge it directly? I tend to read the above
ack as the 2nd option, but given this is only build tested I guess the
first would be better...

Thanks,

Paolo