linux-kernel - Re: [PATCH] fs/xattr: unify *at syscalls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240502-wegweisend-hippen-75aae5b9da3f@brauner>
Date: Thu, 2 May 2024 15:04:26 +0200
From: Christian Brauner <brauner@...nel.org>
To: Jan Kara <jack@...e.cz>
Cc: cgzones@...glemail.com, Jan Kara <jack@...e.com>, 
	Alexander Viro <viro@...iv.linux.org.uk>, Arnd Bergmann <arnd@...db.de>, 
	Thomas Gleixner <tglx@...utronix.de>, Kees Cook <keescook@...omium.org>, 
	Geert Uytterhoeven <geert@...ux-m68k.org>, Casey Schaufler <casey@...aufler-ca.com>, 
	"peterz@...radead.org" <peterz@...radead.org>, Sohil Mehta <sohil.mehta@...el.com>, 
	Miklos Szeredi <mszeredi@...hat.com>, Mark Rutland <mark.rutland@....com>, 
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, linux-api@...r.kernel.org
Subject: Re: [PATCH] fs/xattr: unify *at syscalls

On Thu, May 02, 2024 at 12:37:16PM +0200, Jan Kara wrote:
> On Tue 30-04-24 17:19:14, Christian Göttsche wrote:
> > From: Christian Göttsche <cgzones@...glemail.com>
> > 
> > Use the same parameter ordering for all four newly added *xattrat
> > syscalls:
> > 
> >     dirfd, pathname, at_flags, ...
> > 
> > Also consistently use unsigned int as the type for at_flags.
> > 
> > Suggested-by: Jan Kara <jack@...e.com>
> > Signed-off-by: Christian Göttsche <cgzones@...glemail.com>
> 
> Thanks! The change looks good to me. Christian, do you plan to fold this
> into the series you've taken to your tree?

Yep, that's the plan.