linux-kernel - Re: [PATCH v2] i2c: cadence: Avoid fifo clear after start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c6knga4tuouxir67pzisf64oxfhcy53utunvxz53sbfg2zxfva@cj3r26sfudzb>
Date: Fri, 3 May 2024 20:46:26 +0200
From: Andi Shyti <andi.shyti@...nel.org>
To: Sai Pavan Boddu <sai.pavan.boddu@....com>
Cc: linux-arm-kernel@...ts.infradead.org, linux-i2c@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Michal Simek <michal.simek@....com>, 
	Lars-Peter Clausen <lars@...afoo.de>, Wolfram Sang <wsa@...nel.org>
Subject: Re: [PATCH v2] i2c: cadence: Avoid fifo clear after start

Hi Sai Pavan,

On Fri, May 03, 2024 at 03:12:08PM +0530, Sai Pavan Boddu wrote:
> The Driver unintentionally programs ctrl reg to clear the fifo, which
> happens after the start of transaction. Previously, this was not an issue
> as it involved read-modified-write. However, this issue breaks i2c reads
> on QEMU, as i2c-read is executed before guest starts programming control
> register.
> 
> Fixes: ff0cf7bca630 ("i2c: cadence: Remove unnecessary register reads")
> Signed-off-by: Sai Pavan Boddu <sai.pavan.boddu@....com>
> Acked-by: Michal Simek <michal.simek@....com>

pushed to i2c/i2c-host-fixes.

I will send it for pull request next week as this week is already
too late and I want to see a few rounds of tests before asking
Wolfram to take it.

Thanks,
Andi