Message-ID: <20240503144604.151095-1-ryan.roberts@arm.com>
Date: Fri,  3 May 2024 15:45:58 +0100
From: Ryan Roberts <ryan.roberts@....com>
To: Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will@...nel.org>,
	Joey Gouly <joey.gouly@....com>,
	Ard Biesheuvel <ardb@...nel.org>,
	Mark Rutland <mark.rutland@....com>,
	Anshuman Khandual <anshuman.khandual@....com>,
	David Hildenbrand <david@...hat.com>,
	Peter Xu <peterx@...hat.com>,
	Mike Rapoport <rppt@...ux.ibm.com>,
	Shivansh Vij <shivanshvij@...look.com>
Cc: Ryan Roberts <ryan.roberts@....com>,
	linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH v4 0/4] arm64/mm: Enable userfaultfd write-protect

Hi All,

This series adds uffd write-protect support for arm64.

Previous attempts to add uffd-wp (and soft-dirty) have failed because of a
perceived lack of available PTE SW bits. However it actually turns out that
there are 2 available but they are hidden. PTE_PROT_NONE was previously
occupying a SW bit, but can be moved, freeing up the SW bit. Bit 63 is marked as
"IGNORED" in the Arm ARM, but it does not currently indicate "reserved for SW
use" like it does for the other SW bits. I've confirmed with the spec owner that
this is an oversight; the bit is intended to be reserved for SW use and the spec
will clarify this in a future update.

So now we have two spare bits; patch 4 enables uffd-wp on arm64, using the SW
bit freed up by moving PTE_PROT_NONE. This leaves bit 63 spare for future use
(e.g. soft-dirty - see RFC at [4] - or some other usage).

---

This applies on top of v6.9-rc5.

All mm selftests involving uffd-wp now run. However, this work exposed a bug in
core-mm that was leading to some test uffd-wp failures in the pagemap_ioctl
test. The fix for that is posted at [5], and is in mm-hotfixes-unstable. With
the fix applied, all the uffd-wp tests pass and no other selftest regressions
are observed.


Changes since v3 [3]
====================

patch 1 & 2 (was patch 1):
  - Split into 2 patches (per Anshuman):
     - patch 1: generalizes PMD_PRESENT_INVALID
     - patch 2: removes PTE_PROT_NONE
  - Re-aded comment for PTE_PRESENT_INVALID (per Anshuman)


Changes since v2 [2]
====================

patch 1:
  - Renamed PTE_INVALID -> PTE_PRESENT_INVALID, pte_invalid() ->
    pte_present_invalid() (per Catalin)
  - Added comment explaining test in pte_protnone() (per Will)
  - Added R-b (thanks to Catalin)
patch 2:
  - Move PTE_PRESENT_INVALID to PTE_NG instead of PTE_NS (per Will)
  - Added R-b (thanks to Catalin)
patch 3:
  - Added R-b (thanks to Catalin, David)


Changes since v1 [1]
====================

patch 1 & 2 (was patch 1):
  - generalized PMD_PRESENT_INVALID into PTE_INVALID
  - removed explicit PTE_PROT_NONE bit
patch 3 (was patch 2):
  - collected R-b/A-b from Peter and Catalin - thanks!


[1] https://lore.kernel.org/linux-arm-kernel/20240424111017.3160195-1-ryan.roberts@arm.com/
[2] https://lore.kernel.org/linux-arm-kernel/20240429140208.238056-1-ryan.roberts@arm.com/
[3] https://lore.kernel.org/linux-arm-kernel/20240501145419.1390363-1-ryan.roberts@arm.com/
[4] https://lore.kernel.org/all/20240419074344.2643212-1-ryan.roberts@arm.com/
[5] https://lore.kernel.org/all/20240429114104.182890-1-ryan.roberts@arm.com/

Thanks,
Ryan

Ryan Roberts (4):
  arm64/mm: generalize PMD_PRESENT_INVALID for all levels
  arm64/mm: Remove PTE_PROT_NONE bit
  arm64/mm: Move PTE_PRESENT_INVALID to overlay PTE_NG
  arm64/mm: Add uffd write-protect support

 arch/arm64/Kconfig                    |   1 +
 arch/arm64/include/asm/pgtable-prot.h |  19 +++--
 arch/arm64/include/asm/pgtable.h      | 104 +++++++++++++++++++-------
 3 files changed, 91 insertions(+), 33 deletions(-)

--
2.43.0

Powered by blists - more mailing lists