linux-kernel - Re: [PATCH 2/3] spi: dt-bindings: Add num-cs property for mpfs-spi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7b6489b7-ec9f-4fc7-af72-4d5cc87acd7f@kernel.org>
Date: Fri, 3 May 2024 16:46:13 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Prajna.Rajendrakumar@...rochip.com, broonie@...nel.org
Cc: linux-spi@...r.kernel.org, linux-riscv@...ts.infradead.org,
 Conor.Dooley@...rochip.com, devicetree@...r.kernel.org, robh@...nel.org,
 linux-kernel@...r.kernel.org, krzk+dt@...nel.org,
 Valentina.FernandezAlanis@...rochip.com, Daire.McNamara@...rochip.com
Subject: Re: [PATCH 2/3] spi: dt-bindings: Add num-cs property for mpfs-spi

On 03/05/2024 14:54, Prajna.Rajendrakumar@...rochip.com wrote:
>>
>>> +  - if:
>>> +      properties:
>>> +        compatible:
>>> +          contains:
>>> +            const: microchip,mpfs-spi
>>> +      not:
>>> +        required:
>>> +          - cs-gpios
>>
>> I don't understand what you are expressing here. Did you actually
>> validate it that it achieves exactly what you want?
> 
> Since the controller supports only one chip select, the num-cs should
> default to 1 and cannot exceed 1 unless GPIOs are used as chip selects.

That's not really the answer... or you want to say you did not test it?

Best regards,
Krzysztof