linux-kernel - Re: [PATCH 2/3] spi: dt-bindings: Add num-cs property for mpfs-spi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240503-unfair-charger-8d47fd7b4a91@spud>
Date: Fri, 3 May 2024 17:11:10 +0100
From: Conor Dooley <conor@...nel.org>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Prajna.Rajendrakumar@...rochip.com, broonie@...nel.org,
	linux-spi@...r.kernel.org, linux-riscv@...ts.infradead.org,
	Conor.Dooley@...rochip.com, devicetree@...r.kernel.org,
	robh@...nel.org, linux-kernel@...r.kernel.org, krzk+dt@...nel.org,
	Valentina.FernandezAlanis@...rochip.com,
	Daire.McNamara@...rochip.com
Subject: Re: [PATCH 2/3] spi: dt-bindings: Add num-cs property for mpfs-spi

On Fri, May 03, 2024 at 04:46:13PM +0200, Krzysztof Kozlowski wrote:
> On 03/05/2024 14:54, Prajna.Rajendrakumar@...rochip.com wrote:
> >>
> >>> +  - if:
> >>> +      properties:
> >>> +        compatible:
> >>> +          contains:
> >>> +            const: microchip,mpfs-spi
> >>> +      not:
> >>> +        required:
> >>> +          - cs-gpios
> >>
> >> I don't understand what you are expressing here. Did you actually
> >> validate it that it achieves exactly what you want?
> > 
> > Since the controller supports only one chip select, the num-cs should
> > default to 1 and cannot exceed 1 unless GPIOs are used as chip selects.
> 
> That's not really the answer... or you want to say you did not test it?

She told me she did, and even if she hadn't, I did, despite what my
email earlier today might suggest!

Cheers,
Conor.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)