linux-kernel - Re: [PATCH 2/3] spi: dt-bindings: Add num-cs property for mpfs-spi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1ba98f27f1cc4cd6c3db0b398fa3252c20ef5c3a.camel@microchip.com>
Date: Tue, 7 May 2024 07:57:55 +0000
From: <Prajna.Rajendrakumar@...rochip.com>
To: <broonie@...nel.org>, <krzk@...nel.org>
CC: <linux-spi@...r.kernel.org>, <linux-riscv@...ts.infradead.org>,
	<Conor.Dooley@...rochip.com>, <devicetree@...r.kernel.org>,
	<Valentina.FernandezAlanis@...rochip.com>, <linux-kernel@...r.kernel.org>,
	<krzk+dt@...nel.org>, <robh@...nel.org>, <Daire.McNamara@...rochip.com>,
	<Prajna.Rajendrakumar@...rochip.com>
Subject: Re: [PATCH 2/3] spi: dt-bindings: Add num-cs property for mpfs-spi

On Fri, 2024-05-03 at 16:46 +0200, Krzysztof Kozlowski wrote:
> [Some people who received this message don't often get email from
> krzk@...nel.org. Learn why this is important at 
> https://aka.ms/LearnAboutSenderIdentification ]
> 
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
> 
> On 03/05/2024 14:54, Prajna.Rajendrakumar@...rochip.com wrote:
> > > > +  - if:
> > > > +      properties:
> > > > +        compatible:
> > > > +          contains:
> > > > +            const: microchip,mpfs-spi
> > > > +      not:
> > > > +        required:
> > > > +          - cs-gpios
> > > 
> > > I don't understand what you are expressing here. Did you actually
> > > validate it that it achieves exactly what you want?
> > 
> > Since the controller supports only one chip select, the num-cs
> > should
> > default to 1 and cannot exceed 1 unless GPIOs are used as chip
> > selects.
> 
> That's not really the answer... or you want to say you did not test
> it?
> 
I overlooked mentioning this in my previous reply. It's been thoroughly
validated.

> Best regards,
> Krzysztof
> 
Best regards,
Prajna