linux-kernel - Re: [PATCH] block: fix and simplify blkdevparts= cmdline parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <171475189763.53050.4004560606440063491.b4-ty@kernel.dk>
Date: Fri, 03 May 2024 09:58:17 -0600
From: Jens Axboe <axboe@...nel.dk>
To: INAGAKI Hiroshi <musashino.open@...il.com>
Cc: yang.yang29@....com, justinstitt@...gle.com, xu.panda@....com.cn, 
 linux-block@...r.kernel.org, linux-kernel@...r.kernel.org, 
 Naohiro Aota <naota@...sp.net>
Subject: Re: [PATCH] block: fix and simplify blkdevparts= cmdline parsing


On Sun, 21 Apr 2024 16:39:52 +0900, INAGAKI Hiroshi wrote:
> Fix the cmdline parsing of the "blkdevparts=" parameter using strsep(),
> which makes the code simpler.
> 
> Before commit 146afeb235cc ("block: use strscpy() to instead of
> strncpy()"), we used a strncpy() to copy a block device name and partition
> names. The commit simply replaced a strncpy() and NULL termination with
> a strscpy(). It did not update calculations of length passed to strscpy().
> While the length passed to strncpy() is just a length of valid characters
> without NULL termination ('\0'), strscpy() takes it as a length of the
> destination buffer, including a NULL termination.
> 
> [...]

Applied, thanks!

[1/1] block: fix and simplify blkdevparts= cmdline parsing
      commit: bc2e07dfd2c49aaa4b52302cf7b55cf94e025f79

Best regards,
-- 
Jens Axboe