linux-kernel - Re: [PATCH] iio: temperature: max30208: Remove an unused field in struct max30208

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240504123927.2d47c232@jic23-huawei>
Date: Sat, 4 May 2024 12:39:27 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: Rajat Khandelwal <rajat.khandelwal@...ux.intel.com>, Lars-Peter Clausen
 <lars@...afoo.de>, linux-kernel@...r.kernel.org,
 kernel-janitors@...r.kernel.org, linux-iio@...r.kernel.org
Subject: Re: [PATCH] iio: temperature: max30208: Remove an unused field in
 struct max30208_data

On Wed,  1 May 2024 11:19:41 +0200
Christophe JAILLET <christophe.jaillet@...adoo.fr> wrote:

> In "struct max30208_data", the 'indio_dev' field is unused.
> Remove it.
> 
> Found with cppcheck, unusedStructMember.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Applied,

Thanks,

J
> ---
> Compile tested only.
> 
> It was added in the initial commit 9ee95ae4cffd ("iio: temperature: Add
> driver support for Maxim MAX30208") but was never used.
> ---
>  drivers/iio/temperature/max30208.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/iio/temperature/max30208.c b/drivers/iio/temperature/max30208.c
> index 48be03852cd8..720469f9dc36 100644
> --- a/drivers/iio/temperature/max30208.c
> +++ b/drivers/iio/temperature/max30208.c
> @@ -34,7 +34,6 @@
>  
>  struct max30208_data {
>  	struct i2c_client *client;
> -	struct iio_dev *indio_dev;
>  	struct mutex lock; /* Lock to prevent concurrent reads of temperature readings */
>  };
>