linux-kernel - Re: [PATCH] iio: multiplexer: Remove an unused field in struct mux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240504124131.6c6e3e8e@jic23-huawei>
Date: Sat, 4 May 2024 12:41:31 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: Peter Rosin <peda@...ntia.se>, Lars-Peter Clausen <lars@...afoo.de>,
 linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
 linux-iio@...r.kernel.org
Subject: Re: [PATCH] iio: multiplexer: Remove an unused field in struct mux

On Wed,  1 May 2024 11:41:54 +0200
Christophe JAILLET <christophe.jaillet@...adoo.fr> wrote:

> In "struct mux", the 'indio_dev' field is unused.
> Remove it.
> 
> Found with cppcheck, unusedStructMember.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Applied,

Thanks,

> ---
> Compile tested only.
> 
> It was added in the initial commit 7ba9df54b091 ("iio: multiplexer: new iio
> category and iio-mux driver") but was never used.
> ---
>  drivers/iio/multiplexer/iio-mux.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/iio/multiplexer/iio-mux.c b/drivers/iio/multiplexer/iio-mux.c
> index edd8c69f6d2e..2953403bef53 100644
> --- a/drivers/iio/multiplexer/iio-mux.c
> +++ b/drivers/iio/multiplexer/iio-mux.c
> @@ -30,7 +30,6 @@ struct mux {
>  	int cached_state;
>  	struct mux_control *control;
>  	struct iio_channel *parent;
> -	struct iio_dev *indio_dev;
>  	struct iio_chan_spec *chan;
>  	struct iio_chan_spec_ext_info *ext_info;
>  	struct mux_child *child;