linux-kernel - Re: [PATCH v2] psi: Fix avg trigger being fired unexpectedly.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <182b7a9d-73f7-4529-b053-463eb3684c3f@web.de>
Date: Sat, 4 May 2024 14:34:06 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Levi Yun <ppbuk5246@...il.com>, kernel-janitors@...r.kernel.org,
 Ben Segall <bsegall@...gle.com>,
 Daniel Bristot de Oliveira <bristot@...hat.com>,
 Dietmar Eggemann <dietmar.eggemann@....com>, Ingo Molnar <mingo@...hat.com>,
 Johannes Weiner <hannes@...xchg.org>, Juri Lelli <juri.lelli@...hat.com>,
 Mel Gorman <mgorman@...e.de>, Peter Zijlstra <peterz@...radead.org>,
 Steven Rostedt <rostedt@...dmis.org>, Suren Baghdasaryan
 <surenb@...gle.com>, Valentin Schneider <vschneid@...hat.com>,
 Vincent Guittot <vincent.guittot@...aro.org>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] psi: Fix avg trigger being fired unexpectedly.

…
> But, for PSI_AVGS, win->value should be initialized with group->total[PSI_AVGS].
> Moreover, to get exact initial value for win->value, it should be set
> under each trigger lock to avoid concurrent changes to group->total[].
…
>  kernel/sched/psi.c | 8 +++++---
…

* Can imperative wordings be desirable for such a change description?

* Is there a need to perform proposed adjustments as separate update steps?
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9-rc6#n81

* Would you like to add the tag “Fixes” accordingly?

Regards,
Markus