linux-kernel - Re: [PATCH 14/14] alpha: drop pre-EV56 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <31f1bbfb-733c-4027-834c-98f155562941@linaro.org>
Date: Sat, 4 May 2024 08:00:46 -0700
From: Richard Henderson <richard.henderson@...aro.org>
To: Arnd Bergmann <arnd@...nel.org>, linux-alpha@...r.kernel.org
Cc: Arnd Bergmann <arnd@...db.de>, Ivan Kokshaysky
 <ink@...assic.park.msu.ru>, Matt Turner <mattst88@...il.com>,
 Alexander Viro <viro@...iv.linux.org.uk>, Marc Zyngier <maz@...nel.org>,
 Linus Torvalds <torvalds@...ux-foundation.org>,
 "Paul E. McKenney" <paulmck@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 14/14] alpha: drop pre-EV56 support

On 5/3/24 01:11, Arnd Bergmann wrote:
>   
> -/* Flush just one page in the current TLB set.  We need to be very
> -   careful about the icache here, there is no way to invalidate a
> -   specific icache page.  */
> -
> -__EXTERN_INLINE void
> -ev4_flush_tlb_current_page(struct mm_struct * mm,
> -			   struct vm_area_struct *vma,
> -			   unsigned long addr)
> -{
> -	int tbi_flag = 2;
> -	if (vma->vm_flags & VM_EXEC) {
> -		__load_new_mm_context(mm);
> -		tbi_flag = 3;
> -	}
> -	tbi(tbi_flag, addr);
> -}
> -
>   __EXTERN_INLINE void
>   ev5_flush_tlb_current_page(struct mm_struct * mm,
>   			   struct vm_area_struct *vma,

The comment being removed applied to both functions and still applies to 
ev5_flush_tlb_current_page.  (Thus __load_new_mm_context instead of a tbi.)

r~