linux-kernel - Re: [PATCH 14/14] alpha: drop pre-EV56 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <ae56021f-1e85-4dd9-a4ca-5a8773d51ea1@app.fastmail.com>
Date: Mon, 06 May 2024 12:06:35 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: "Richard Henderson" <richard.henderson@...aro.org>,
 "Arnd Bergmann" <arnd@...nel.org>, linux-alpha@...r.kernel.org
Cc: "Ivan Kokshaysky" <ink@...assic.park.msu.ru>,
 "Matt Turner" <mattst88@...il.com>,
 "Alexander Viro" <viro@...iv.linux.org.uk>, "Marc Zyngier" <maz@...nel.org>,
 "Linus Torvalds" <torvalds@...ux-foundation.org>,
 "Paul E. McKenney" <paulmck@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 14/14] alpha: drop pre-EV56 support

On Sat, May 4, 2024, at 17:00, Richard Henderson wrote:
> On 5/3/24 01:11, Arnd Bergmann wrote:
>>   
>> -/* Flush just one page in the current TLB set.  We need to be very
>> -   careful about the icache here, there is no way to invalidate a
>> -   specific icache page.  */
>> -
>> -__EXTERN_INLINE void
>> -ev4_flush_tlb_current_page(struct mm_struct * mm,
>> -			   struct vm_area_struct *vma,
>> -			   unsigned long addr)
>> -{
>> -	int tbi_flag = 2;
>> -	if (vma->vm_flags & VM_EXEC) {
>> -		__load_new_mm_context(mm);
>> -		tbi_flag = 3;
>> -	}
>> -	tbi(tbi_flag, addr);
>> -}
>> -
>>   __EXTERN_INLINE void
>>   ev5_flush_tlb_current_page(struct mm_struct * mm,
>>   			   struct vm_area_struct *vma,
>
> The comment being removed applied to both functions and still applies to 
> ev5_flush_tlb_current_page.  (Thus __load_new_mm_context instead of a tbi.)

Fixed now, thanks for taking a look!

     Arnd