linux-kernel - Re: [PATCH RESEND v6 2/2] scripts: checkpatch: check unused parameters for function-like macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5e26f82913801050afa4442dfb9a07249895ab98.camel@perches.com>
Date: Sun, 05 May 2024 22:33:18 -0700
From: Joe Perches <joe@...ches.com>
To: Barry Song <21cnbao@...il.com>, akpm@...ux-foundation.org, 
	linux-doc@...r.kernel.org
Cc: apw@...onical.com, broonie@...nel.org, chenhuacai@...ngson.cn, 
 chris@...kel.net, corbet@....net, dwaipayanray1@...il.com, 
 herbert@...dor.apana.org.au, linux-kernel@...r.kernel.org,
 linux@...ck-us.net,  lukas.bulwahn@...il.com, mac.xxn@...look.com,
 sfr@...b.auug.org.au,  v-songbaohua@...o.com, workflows@...r.kernel.org,
 Max Filippov <jcmvbkbc@...il.com>,  Jeff Johnson
 <quic_jjohnson@...cinc.com>, Charlemagne Lasse <charlemagnelasse@...il.com>
Subject: Re: [PATCH RESEND v6 2/2] scripts: checkpatch: check unused
 parameters for function-like macro

On Mon, 2024-05-06 at 13:46 +1200, Barry Song wrote:
> From: Xining Xu <mac.xxn@...look.com>
> 
> If function-like macros do not utilize a parameter, it might result in a
> build warning.  In our coding style guidelines, we advocate for utilizing
> static inline functions to replace such macros.  This patch verifies
> compliance with the new rule.
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -6040,6 +6040,12 @@ sub process {
>  					CHK("MACRO_ARG_PRECEDENCE",
>  					    "Macro argument '$arg' may be better as '($arg)' to avoid precedence issues\n" . "$herectx");
>  				}
> +
> +# check if this is an unused argument
> +				if ($define_stmt !~ /\b$arg\b/) {
> +					WARN("MACRO_ARG_UNUSED",
> +						"Argument '$arg' is not used in function-like macro\n" . "$herectx");

trivia:  This should be aligned to the open parenthesis.

Otherwise:
Acked-by: Joe Perches <joe@...ches.com>