lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon,  6 May 2024 19:16:57 +1200
From: Barry Song <21cnbao@...il.com>
To: joe@...ches.com
Cc: akpm@...ux-foundation.org,
	apw@...onical.com,
	broonie@...nel.org,
	charlemagnelasse@...il.com,
	chenhuacai@...ngson.cn,
	chris@...kel.net,
	corbet@....net,
	dwaipayanray1@...il.com,
	herbert@...dor.apana.org.au,
	jcmvbkbc@...il.com,
	linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	linux@...ck-us.net,
	lukas.bulwahn@...il.com,
	mac.xxn@...look.com,
	quic_jjohnson@...cinc.com,
	sfr@...b.auug.org.au,
	v-songbaohua@...o.com,
	workflows@...r.kernel.org
Subject: Re: [PATCH RESEND v6 2/2] scripts: checkpatch: check unused parameters for function-like macro

>> From: Xining Xu <mac.xxn@...look.com>
>> 
>> If function-like macros do not utilize a parameter, it might result in a
>> build warning.  In our coding style guidelines, we advocate for utilizing
>> static inline functions to replace such macros.  This patch verifies
>> compliance with the new rule.
> []
>> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> []
>> @@ -6040,6 +6040,12 @@ sub process {
>>  					CHK("MACRO_ARG_PRECEDENCE",
>>  					    "Macro argument '$arg' may be better as '($arg)' to avoid precedence issues\n" . "$herectx");
>>  				}
>> +
>> +# check if this is an unused argument
>> +				if ($define_stmt !~ /\b$arg\b/) {
>> +					WARN("MACRO_ARG_UNUSED",
>> +						"Argument '$arg' is not used in function-like macro\n" . "$herectx");
> 
> trivia:  This should be aligned to the open parenthesis.
> 

Hi Joe,
I assume you mean the below?

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 9895d7e38a9f..2b812210b412 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -6044,7 +6044,7 @@ sub process {
 # check if this is an unused argument
 				if ($define_stmt !~ /\b$arg\b/) {
 					WARN("MACRO_ARG_UNUSED",
-						"Argument '$arg' is not used in function-like macro\n" . "$herectx");
+					     "Argument '$arg' is not used in function-like macro\n" . "$herectx");
 				}
 			}
> Otherwise:
> Acked-by: Joe Perches <joe@...ches.com>

Thanks!

-Barry


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ