linux-kernel - Re: [PATCH v2] HID: playstation: DS4: Fix calibration workaround for clone devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.2405062331420.16865@cbobk.fhfr.pm>
Date: Mon, 6 May 2024 23:32:14 +0200 (CEST)
From: Jiri Kosina <jikos@...nel.org>
To: Max Staudt <max@...as.org>
cc: Roderick Colenbrander <roderick.colenbrander@...y.com>, 
    Benjamin Tissoires <benjamin.tissoires@...hat.com>, 
    linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] HID: playstation: DS4: Fix calibration workaround
 for clone devices

On Sun, 5 May 2024, Max Staudt wrote:

> The logic in dualshock4_get_calibration_data() used uninitialised data
> in case of a failed kzalloc() for the transfer buffer.

Good catch, this completely escaped my attention during review.

> 
> The solution is to group all business logic and all sanity checks
> together, and jump only to the latter in case of an error.
> While we're at it, factor out the axes' labelling, since it must happen
> either way for input_report_abs() to succeed later on.
> 
> Thanks to Dan Carpenter for the Smatch static checker warning.
> 
> Fixes: a48a7cd85f55 ("HID: playstation: DS4: Don't fail on calibration data request")
> Signed-off-by: Max Staudt <max@...as.org>

Now queued on top of the for-6.10/playstation pile in hid.git.

Thanks,

-- 
Jiri Kosina
SUSE Labs