linux-kernel - [PATCH v2 0/2] Print names of apicv inhibit reasons in traces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date: Mon,  6 May 2024 22:53:19 +0000
From: Alejandro Jimenez <alejandro.j.jimenez@...cle.com>
To: kvm@...r.kernel.org, seanjc@...gle.com, vasant.hegde@....com
Cc: pbonzini@...hat.com, linux-kernel@...r.kernel.org,
        joao.m.martins@...cle.com, boris.ostrovsky@...cle.com,
        suravee.suthikulpanit@....com, mlevitsk@...hat.com,
        alejandro.j.jimenez@...cle.com
Subject: [PATCH v2 0/2] Print names of apicv inhibit reasons in traces

v2:
- Use Sean's implementation/patch from v1: https://lore.kernel.org/all/ZjVQOFLXWrZvoa-Y@google.com/
- Fix typo in commit message (s/inhbit/inhibit).
- Add patch renaming APICV_INHIBIT_REASON_DISABLE to APICV_INHIBIT_REASON_DISABLED.
- Drop Vasant's R-b from v1 since implementation was refined, even though the
general approach and behavior remains the same.

v1: https://lore.kernel.org/all/20240214223554.1033154-1-alejandro.j.jimenez@oracle.com/

Tested on Genoa system. With the proposed changes, the tracepoint output looks
like the following examples:

 qemu-system-x86-7068    [194] .....  1397.647770: kvm_apicv_inhibit_changed: set reason=2, inhibits=0x4 ABSENT
 qemu-system-x86-7068    [003] .....  1397.676703: kvm_apicv_inhibit_changed: cleared reason=2, inhibits=0x0
 qemu-system-x86-7074    [247] .....  1397.701398: kvm_apicv_inhibit_changed: cleared reason=4, inhibits=0x0

 qemu-system-x86-7074    [008] .....  1408.697413: kvm_apicv_inhibit_changed: set reason=8, inhibits=0x100 IRQWIN
 qemu-system-x86-7074    [008] .....  1408.697420: kvm_apicv_inhibit_changed: cleared reason=8, inhibits=0x0

[...]

 qemu-system-x86-7173    [056] .....  1570.541372: kvm_apicv_inhibit_changed: set reason=8, inhibits=0x300 IRQWIN|PIT_REINJ
 qemu-system-x86-7173    [056] .....  1570.541380: kvm_apicv_inhibit_changed: cleared reason=8, inhibits=0x200 PIT_REINJ


Alejandro Jimenez (2):
  KVM: x86: Print names of apicv inhibit reasons in traces
  KVM: x86: Keep consistent naming for APICv/AVIC inhibit reasons

 arch/x86/include/asm/kvm_host.h | 21 ++++++++++++++++++++-
 arch/x86/kvm/svm/svm.h          |  2 +-
 arch/x86/kvm/trace.h            |  9 +++++++--
 arch/x86/kvm/vmx/main.c         |  2 +-
 arch/x86/kvm/x86.c              |  6 +++++-
 5 files changed, 34 insertions(+), 6 deletions(-)


base-commit: d91a9cc16417b8247213a0144a1f0fd61dc855dd
-- 
2.39.3