linux-kernel - Re: [PATCH v2 11/12] fbdev/smscufx: Make I2C terminology more inclusive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8287802e-ac85-43c6-8d29-6841ce3b14e0@suse.de>
Date: Mon, 6 May 2024 11:21:47 +0200
From: Thomas Zimmermann <tzimmermann@...e.de>
To: Easwar Hariharan <eahariha@...ux.microsoft.com>,
 Steve Glendinning <steve.glendinning@...well.net>,
 Helge Deller <deller@....de>,
 "open list:SMSC UFX6000 and UFX7000 USB to VGA DRIVER"
 <linux-fbdev@...r.kernel.org>,
 "open list:FRAMEBUFFER LAYER" <dri-devel@...ts.freedesktop.org>,
 open list <linux-kernel@...r.kernel.org>
Cc: Wolfram Sang <wsa+renesas@...g-engineering.com>,
 "open list:RADEON and AMDGPU DRM DRIVERS" <amd-gfx@...ts.freedesktop.org>,
 "open list:INTEL DRM DISPLAY FOR XE AND I915 DRIVERS"
 <intel-gfx@...ts.freedesktop.org>,
 "open list:INTEL DRM DISPLAY FOR XE AND I915 DRIVERS"
 <intel-xe@...ts.freedesktop.org>,
 "open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS"
 <nouveau@...ts.freedesktop.org>,
 "open list:I2C SUBSYSTEM HOST DRIVERS" <linux-i2c@...r.kernel.org>,
 "open list:BTTV VIDEO4LINUX DRIVER" <linux-media@...r.kernel.org>
Subject: Re: [PATCH v2 11/12] fbdev/smscufx: Make I2C terminology more
 inclusive



Am 03.05.24 um 20:13 schrieb Easwar Hariharan:
> I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave"
> with more appropriate terms. Inspired by and following on to Wolfram's
> series to fix drivers/i2c/[1], fix the terminology for users of
> I2C_ALGOBIT bitbanging interface, now that the approved verbiage exists
> in the specification.
>
> Compile tested, no functionality changes intended
>
> [1]: https://lore.kernel.org/all/20240322132619.6389-1-wsa+renesas@sang-engineering.com/
>
> Signed-off-by: Easwar Hariharan <eahariha@...ux.microsoft.com>

Acked-by: Thomas Zimmermann <tzimmermann@...e.de>

> ---
>   drivers/video/fbdev/smscufx.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/smscufx.c b/drivers/video/fbdev/smscufx.c
> index 35d682b110c4..5f0dd01fd834 100644
> --- a/drivers/video/fbdev/smscufx.c
> +++ b/drivers/video/fbdev/smscufx.c
> @@ -1292,7 +1292,7 @@ static int ufx_realloc_framebuffer(struct ufx_data *dev, struct fb_info *info)
>   	return 0;
>   }
>   
> -/* sets up I2C Controller for 100 Kbps, std. speed, 7-bit addr, master,
> +/* sets up DDC channel for 100 Kbps, std. speed, 7-bit addr, controller mode,
>    * restart enabled, but no start byte, enable controller */
>   static int ufx_i2c_init(struct ufx_data *dev)
>   {
> @@ -1321,7 +1321,7 @@ static int ufx_i2c_init(struct ufx_data *dev)
>   	/* 7-bit (not 10-bit) addressing */
>   	tmp &= ~(0x10);
>   
> -	/* enable restart conditions and master mode */
> +	/* enable restart conditions and controller mode */
>   	tmp |= 0x21;
>   
>   	status = ufx_reg_write(dev, 0x1000, tmp);

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)