linux-kernel - Re: [PATCH] x86: ce4100: Remove unused struct 'sim_reg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZjjsiO33y08dJLPX@gallifrey>
Date: Mon, 6 May 2024 14:43:20 +0000
From: "Dr. David Alan Gilbert" <linux@...blig.org>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: bhelgaas@...gle.com, dave.hansen@...ux.intel.com, x86@...nel.org,
	linux-pci@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: ce4100: Remove unused struct 'sim_reg_op'

* Ilpo Järvinen (ilpo.jarvinen@...ux.intel.com) wrote:
> On Mon, 6 May 2024, linux@...blig.org wrote:
> 
> > From: "Dr. David Alan Gilbert" <linux@...blig.org>
> > 
> > This doesn't look like it was ever used.
> 
> Don't start with "This" but spell what you're talking about out so it 
> can be read and understood without shortlog in Subject (or looking into 
> the code change).

I'm of course happy to rework that if it helps you, although
I thought the subject line was sufficient.

Dave

> > Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>
> > ---
> >  arch/x86/pci/ce4100.c | 6 ------
> >  1 file changed, 6 deletions(-)
> > 
> > diff --git a/arch/x86/pci/ce4100.c b/arch/x86/pci/ce4100.c
> > index 87313701f069e..f5dbd25651e0f 100644
> > --- a/arch/x86/pci/ce4100.c
> > +++ b/arch/x86/pci/ce4100.c
> > @@ -35,12 +35,6 @@ struct sim_dev_reg {
> >  	struct sim_reg sim_reg;
> >  };
> >  
> > -struct sim_reg_op {
> > -	void (*init)(struct sim_dev_reg *reg);
> > -	void (*read)(struct sim_dev_reg *reg, u32 value);
> > -	void (*write)(struct sim_dev_reg *reg, u32 value);
> > -};
> > -
> >  #define MB (1024 * 1024)
> >  #define KB (1024)
> >  #define SIZE_TO_MASK(size) (~(size - 1))
> > 
> 
> -- 
>  i.
> 
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/