[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240506152304.GA1699729@bhelgaas>
Date: Mon, 6 May 2024 10:23:04 -0500
From: Bjorn Helgaas <helgaas@...nel.org>
To: "Dr. David Alan Gilbert" <linux@...blig.org>
Cc: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
bhelgaas@...gle.com, dave.hansen@...ux.intel.com, x86@...nel.org,
linux-pci@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: ce4100: Remove unused struct 'sim_reg_op'
On Mon, May 06, 2024 at 02:43:20PM +0000, Dr. David Alan Gilbert wrote:
> * Ilpo Järvinen (ilpo.jarvinen@...ux.intel.com) wrote:
> > On Mon, 6 May 2024, linux@...blig.org wrote:
> >
> > > From: "Dr. David Alan Gilbert" <linux@...blig.org>
> > >
> > > This doesn't look like it was ever used.
> >
> > Don't start with "This" but spell what you're talking about out so it
> > can be read and understood without shortlog in Subject (or looking into
> > the code change).
>
> I'm of course happy to rework that if it helps you, although
> I thought the subject line was sufficient.
It's a minor point, to be sure. The way I think about this is "an
essay title is not part of the essay itself," so the essay (commit
log) should make sense all by itself.
Bjorn
Powered by blists - more mailing lists