linux-kernel - Re: [PATCH] x86: ce4100: Remove unused struct 'sim_reg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zjq4KWSh63P6Y_Zg@gallifrey>
Date: Tue, 7 May 2024 23:24:25 +0000
From: "Dr. David Alan Gilbert" <linux@...blig.org>
To: Bjorn Helgaas <helgaas@...nel.org>
Cc: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
	bhelgaas@...gle.com, dave.hansen@...ux.intel.com, x86@...nel.org,
	linux-pci@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: ce4100: Remove unused struct 'sim_reg_op'

* Bjorn Helgaas (helgaas@...nel.org) wrote:
> On Mon, May 06, 2024 at 02:43:20PM +0000, Dr. David Alan Gilbert wrote:
> > * Ilpo Järvinen (ilpo.jarvinen@...ux.intel.com) wrote:
> > > On Mon, 6 May 2024, linux@...blig.org wrote:
> > > 
> > > > From: "Dr. David Alan Gilbert" <linux@...blig.org>
> > > > 
> > > > This doesn't look like it was ever used.
> > > 
> > > Don't start with "This" but spell what you're talking about out so it 
> > > can be read and understood without shortlog in Subject (or looking into 
> > > the code change).
> > 
> > I'm of course happy to rework that if it helps you, although
> > I thought the subject line was sufficient.
> 
> It's a minor point, to be sure.  The way I think about this is "an
> essay title is not part of the essay itself," so the essay (commit
> log) should make sense all by itself.

OK, modified v2 sent.

Dave

> Bjorn
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/