linux-kernel - Re: [PATCH net v3 1/2] ax25: Fix reference count leak issues of ax25_dev and net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7582e197-122c-4682-b9e2-53bfc386d870@web.de>
Date: Mon, 6 May 2024 17:11:31 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Dan Carpenter <dan.carpenter@...aro.org>,
 Duoming Zhou <duoming@....edu.cn>, linux-hams@...r.kernel.org,
 netdev@...r.kernel.org, kernel-janitors@...r.kernel.org
Cc: "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Jörg Reuter <jreuter@...na.de>,
 Paolo Abeni <pabeni@...hat.com>, LKML <linux-kernel@...r.kernel.org>,
 Lars Kellogg-Stedman <lars@...bit.com>, Simon Horman <horms@...nel.org>
Subject: Re: [PATCH net v3 1/2] ax25: Fix reference count leak issues of
 ax25_dev and net_device

> The ax25_addr_ax25dev() exists a reference count leak issue of the
> object "ax25_dev" and the ax25_dev_device_down() exists reference
> count leak issues of the objects "ax25_dev" and "net_device".

I find that such a wording for the introduction of adjustments needs
further improvements.

How do you think about to offer changes for the affected two function
implementations as separate update steps?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9-rc7#n81

Regards,
Markus