linux-kernel - Re: [PATCH v3 1/8] arm64/sysreg: Add definitions for immediate versions of MSR ALLINT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zjjz-tzLRC2nH51A@finisterre.sirena.org.uk>
Date: Tue, 7 May 2024 00:15:06 +0900
From: Mark Brown <broonie@...nel.org>
To: Mark Rutland <mark.rutland@....com>
Cc: Liao Chang <liaochang1@...wei.com>, catalin.marinas@....com,
	will@...nel.org, maz@...nel.org, oliver.upton@...ux.dev,
	james.morse@....com, suzuki.poulose@....com, yuzenghui@...wei.com,
	tglx@...utronix.de, ardb@...nel.org, anshuman.khandual@....com,
	miguel.luis@...cle.com, joey.gouly@....com, ryan.roberts@....com,
	jeremy.linton@....com, ericchancf@...gle.com,
	kristina.martsenko@....com, robh@...nel.org,
	scott@...amperecomputing.com, songshuaishuai@...ylab.org,
	shijie@...amperecomputing.com, akpm@...ux-foundation.org,
	bhe@...hat.com, horms@...nel.org, mhiramat@...nel.org,
	rmk+kernel@...linux.org.uk, shahuang@...hat.com,
	takakura@...inux.co.jp, dianders@...omium.org, swboyd@...omium.org,
	sumit.garg@...aro.org, frederic@...nel.org, reijiw@...gle.com,
	akihiko.odaki@...nix.com, ruanjinjie@...wei.com,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	kvmarm@...ts.linux.dev
Subject: Re: [PATCH v3 1/8] arm64/sysreg: Add definitions for immediate
 versions of MSR ALLINT

On Fri, May 03, 2024 at 05:00:49PM +0100, Mark Rutland wrote:
> On Mon, Apr 15, 2024 at 06:47:51AM +0000, Liao Chang wrote:

> +#define PSTATE_ALLINT                  pstate_field(1, 0)

> +#define set_pstate_allint(x)           asm volatile(SET_PSTATE_ALLINT(x))

Hrm, those helpers are not ideally discoverable, partly due to the
system register description for ALLINT not providing any references to
this being a general scheme (which is fixable there) and partly due to
the use of __emit_inst() with a numeric literal - we should probably add
a comment next to the __emit_inst() saying what instruction we are
emitting.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)