linux-kernel - Re: [PATCH v18 12/21] dm: add finalize hook to target

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aa767961-5e3-2ceb-1a1e-ff66a8eed649@redhat.com>
Date: Wed, 8 May 2024 19:17:34 +0200 (CEST)
From: Mikulas Patocka <mpatocka@...hat.com>
To: Fan Wu <wufan@...ux.microsoft.com>
cc: corbet@....net, zohar@...ux.ibm.com, jmorris@...ei.org, serge@...lyn.com, 
    tytso@....edu, ebiggers@...nel.org, axboe@...nel.dk, agk@...hat.com, 
    snitzer@...nel.org, eparis@...hat.com, paul@...l-moore.com, 
    linux-doc@...r.kernel.org, linux-integrity@...r.kernel.org, 
    linux-security-module@...r.kernel.org, fsverity@...ts.linux.dev, 
    linux-block@...r.kernel.org, dm-devel@...ts.linux.dev, 
    audit@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v18 12/21] dm: add finalize hook to target_type



On Fri, 3 May 2024, Fan Wu wrote:

> This patch adds a target finalize hook.
> 
> The hook is triggered just before activating an inactive table of a
> mapped device. If it returns an error the __bind get cancelled.
> 
> The dm-verity target will use this hook to attach the dm-verity's
> roothash metadata to the block_device struct of the mapped device.
> 
> Signed-off-by: Fan Wu <wufan@...ux.microsoft.com>

Hi

Why not use the preresume callback?

Is there some reason why do we need a new callback instead of using the 
existing one?

Mikulas