linux-kernel - Re: [PATCH v2 3/4] thermal: intel: hfi: Rename HFI_MAX_THERM_NOTIFY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 8 May 2024 04:46:49 +0000
From: "Zhang, Rui" <rui.zhang@...el.com>
To: "ricardo.neri-calderon@...ux.intel.com"
	<ricardo.neri-calderon@...ux.intel.com>, "Wysocki, Rafael J"
	<rafael.j.wysocki@...el.com>
CC: "srinivas.pandruvada@...ux.intel.com"
	<srinivas.pandruvada@...ux.intel.com>, "Brown, Len" <len.brown@...el.com>,
	"stanislaw.gruszka@...ux.intel.com" <stanislaw.gruszka@...ux.intel.com>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "Neri,
 Ricardo" <ricardo.neri@...el.com>
Subject: Re: [PATCH v2 3/4] thermal: intel: hfi: Rename
 HFI_MAX_THERM_NOTIFY_COUNT

On Tue, 2024-05-07 at 20:43 -0700, Ricardo Neri wrote:
> When processing a hardware update, HFI generates as many thermal
> netlink
> events as needed to relay all the updated CPU capabilities to user
> space.
> The constant HFI_MAX_THERM_NOTIFY_COUNT is the number of CPU
> capabilities
> updated per each of those events.
> 
> Give this constant a more descriptive name.
> 
> Signed-off-by: Ricardo Neri <ricardo.neri-calderon@...ux.intel.com>

Acked-by: Zhang Rui <rui.zhang@...el.com>

-rui
> ---
> Cc: Len Brown <len.brown@...el.com>
> Cc: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
> Cc: Stanislaw Gruszka <stanislaw.gruszka@...ux.intel.com>
> Cc: Zhang Rui <rui.zhang@...el.com>
> Cc: linux-pm@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> ---
> Changes since v1:
>  * None
> ---
>  drivers/thermal/intel/intel_hfi.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/thermal/intel/intel_hfi.c
> b/drivers/thermal/intel/intel_hfi.c
> index d82b8788b0f8..c6658f8c5cca 100644
> --- a/drivers/thermal/intel/intel_hfi.c
> +++ b/drivers/thermal/intel/intel_hfi.c
> @@ -167,7 +167,7 @@ static DEFINE_MUTEX(hfi_instance_lock);
>  
>  static struct workqueue_struct *hfi_updates_wq;
>  #define HFI_UPDATE_DELAY_MS            100
> -#define HFI_MAX_THERM_NOTIFY_COUNT     16
> +#define HFI_THERMNL_CAPS_PER_EVENT     16
>  
>  static void get_hfi_caps(struct hfi_instance *hfi_instance,
>                          struct thermal_genl_cpu_caps *cpu_caps)
> @@ -218,14 +218,14 @@ static void update_capabilities(struct
> hfi_instance *hfi_instance)
>  
>         get_hfi_caps(hfi_instance, cpu_caps);
>  
> -       if (cpu_count < HFI_MAX_THERM_NOTIFY_COUNT)
> +       if (cpu_count < HFI_THERMNL_CAPS_PER_EVENT)
>                 goto last_cmd;
>  
> -       /* Process complete chunks of HFI_MAX_THERM_NOTIFY_COUNT
> capabilities. */
> +       /* Process complete chunks of HFI_THERMNL_CAPS_PER_EVENT
> capabilities. */
>         for (i = 0;
> -            (i + HFI_MAX_THERM_NOTIFY_COUNT) <= cpu_count;
> -            i += HFI_MAX_THERM_NOTIFY_COUNT)
> -
>                thermal_genl_cpu_capability_event(HFI_MAX_THERM_NOTIFY_
> COUNT,
> +            (i + HFI_THERMNL_CAPS_PER_EVENT) <= cpu_count;
> +            i += HFI_THERMNL_CAPS_PER_EVENT)
> +               thermal_genl_cpu_capability_event(HFI_THERMNL_CAPS_PE
> R_EVENT,
>                                                   &cpu_caps[i]);
>  
>         cpu_count = cpu_count - i;