linux-kernel - Re: [Intel-wired-lan] [PATCH] e1000e: fix link fluctuations problem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <367fc6ac-cad3-4b2b-9456-2859f1bd4be3@intel.com>
Date: Wed, 8 May 2024 07:46:48 +0300
From: Sasha Neftin <sasha.neftin@...el.com>
To: Andrew Lunn <andrew@...n.ch>, En-Wei WU <en-wei.wu@...onical.com>
CC: <jesse.brandeburg@...el.co>, <netdev@...r.kernel.org>,
	<rickywu0421@...il.com>, <linux-kernel@...r.kernel.org>,
	<edumazet@...gle.com>, <intel-wired-lan@...ts.osuosl.org>, <kuba@...nel.org>,
	<anthony.l.nguyen@...el.com>, <pabeni@...hat.com>, <davem@...emloft.net>,
	"Ruinskiy, Dima" <dima.ruinskiy@...el.com>, "Lifshits, Vitaly"
	<vitaly.lifshits@...el.com>, "Neftin, Sasha" <sasha.neftin@...el.com>,
	"Nguyen, Anthony L" <anthony.l.nguyen@...el.com>, "Keller, Jacob E"
	<jacob.e.keller@...el.com>, "Avivi, Amir" <amir.avivi@...el.com>
Subject: Re: [Intel-wired-lan] [PATCH] e1000e: fix link fluctuations problem

On 07/05/2024 15:10, Andrew Lunn wrote:
> On Tue, May 07, 2024 at 11:24:05AM +0200, En-Wei WU wrote:
>>> Why PHY is this?
>> It's the Intel I219-LM, and I haven't found any other device having
>> the same issue.
> 
> There is no Linux PHY driver for this device, only the code buried in
> the e1000e MAC driver. Sometimes Intel use Marvell PHYs, and there are
> a couple of work arounds in the Marvell PHY driver, which might of
> given you a clue. But not in this case...

In I219-* parts used LSI PHY. This PHY is compliant with the 802.3 IEEE 
standard if I recall correctly. Auto-negotiation and link establishment 
are processed following the IEEE standard and could vary from platform 
to platform but are not violent to the IEEE standard.

En-Wei, My recommendation is not to accept these patches. If you think 
there is a HW/PHY problem - open a ticket on Intel PAE.

Sasha

> 
>        Andrew