linux-kernel - Re: [PATCH] ALSA: hda: hda_component: Initialize shared data during bind callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <874jb8cwjk.wl-tiwai@suse.de>
Date: Wed, 08 May 2024 14:34:07 +0200
From: Takashi Iwai <tiwai@...e.de>
To: Richard Fitzgerald <rf@...nsource.cirrus.com>
Cc: <tiwai@...e.com>,
	<linux-kernel@...r.kernel.org>,
	<patches@...nsource.cirrus.com>,
	<alsa-devel@...a-project.org>,
	<linux-sound@...r.kernel.org>
Subject: Re: [PATCH] ALSA: hda: hda_component: Initialize shared data during bind callback

On Wed, 08 May 2024 12:03:47 +0200,
Richard Fitzgerald wrote:
> 
> Move the initialization of the shared struct hda_component array into
> hda_component_manager_bind().
> 
> The purpose of the manager bind() callback is to allow it to perform
> initialization before binding in the component drivers. This is the
> correct place to initialize the shared data.
> 
> The original implementation initialized the shared data in
> hda_component_manager_init(). This is only done once during probe()
> of the manager driver. So if the component binding was unbound and
> then rebound, the shared data would not be re-initialized.
> 
> Signed-off-by: Richard Fitzgerald <rf@...nsource.cirrus.com>
> Fixes: fd895a74dc1d ("ALSA: hda: realtek: Move hda_component implementation to module")

Applied now.  Thanks.


Takashi