linux-kernel - Re: [PATCH] ALSA: hda: cs35l56: Fix lifetime of cs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8734qscwj9.wl-tiwai@suse.de>
Date: Wed, 08 May 2024 14:34:18 +0200
From: Takashi Iwai <tiwai@...e.de>
To: Richard Fitzgerald <rf@...nsource.cirrus.com>
Cc: <tiwai@...e.com>,
	<linux-kernel@...r.kernel.org>,
	<patches@...nsource.cirrus.com>,
	<alsa-devel@...a-project.org>,
	<linux-sound@...r.kernel.org>
Subject: Re: [PATCH] ALSA: hda: cs35l56: Fix lifetime of cs_dsp instance

On Wed, 08 May 2024 12:08:11 +0200,
Richard Fitzgerald wrote:
> 
> The cs_dsp instance is initialized in the driver probe() so it
> should be freed in the driver remove(). Also fix a missing call
> to cs_dsp_remove() in the error path of cs35l56_hda_common_probe().
> 
> The call to cs_dsp_remove() was being done in the component unbind
> callback cs35l56_hda_unbind(). This meant that if the driver was
> unbound and then re-bound it would be using an uninitialized cs_dsp
> instance.
> 
> It is best to initialize the cs_dsp instance in probe() so that it
> can return an error if it fails. The component binding API doesn't
> have any error handling so there's no way to handle a failure if
> cs_dsp was initialized in the bind.
> 
> Signed-off-by: Richard Fitzgerald <rf@...nsource.cirrus.com>
> Fixes: 73cfbfa9caea ("ALSA: hda/cs35l56: Add driver for Cirrus Logic CS35L56 amplifier")

Applied now.  Thanks.


Takashi