linux-kernel - Re: [PATCH] samples: qmi: Convert to platform remove callback returning void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ealrtx5jnk43tt47rvjyipj2vr7f6noau44p5mw74invmb23oj@wvbovzbx54tt>
Date: Wed, 8 May 2024 16:01:30 +0200
From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To: Bjorn Andersson <andersson@...nel.org>
Cc: linux-kernel@...r.kernel.org, kernel@...gutronix.de, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] samples: qmi: Convert to platform remove callback
 returning void

Hello Bjorn,

On Fri, Apr 12, 2024 at 02:20:12PM +0200, Uwe Kleine-König wrote:
> On Fri, Mar 08, 2024 at 09:51:21AM +0100, Uwe Kleine-König wrote:
> > The .remove() callback for a platform driver returns an int which makes
> > many driver authors wrongly assume it's possible to do error handling by
> > returning an error code. However the value returned is ignored (apart
> > from emitting a warning) and this typically results in resource leaks.
> > 
> > To improve here there is a quest to make the remove callback return
> > void. In the first step of this quest all drivers are converted to
> > .remove_new(), which already returns void. Eventually after all drivers
> > are converted, .remove_new() will be renamed to .remove().
> > 
> > Trivially convert this driver from always returning zero in the remove
> > callback to the void returning variant.
> > 
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> 
> This patch didn't receive any feedback yet, I guess because I used an
> old email address for Bjorn. I updated the address for this mail now.
> 
> Would you consider applying this patch; please tell me if I should
> resend.

I intend to change struct platform_driver after the upcoming merge
window. So if this patch doesn't go in, please accept me sending it
together with the actual change to struct platform_driver to Greg.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)