linux-kernel - Re: [RFC PATCH v2 3/3] ACPI: extlog: Make print_extlog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7009544.jJDZkT8p0M@fdefranc-mobl3>
Date: Fri, 10 May 2024 21:00:34 +0200
From: "Fabio M. De Francesco" <fabio.m.de.francesco@...ux.intel.com>
To: Borislav Petkov <bp@...en8.de>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>, Len Brown <lenb@...nel.org>,
 Tony Luck <tony.luck@...el.com>, linux-acpi@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-edac@...r.kernel.org,
 Dan Williams <dan.j.williams@...el.com>
Subject:
 Re: [RFC PATCH v2 3/3] ACPI: extlog: Make print_extlog_rcd() log
 unconditionally

On Friday, May 10, 2024 2:52:14 PM GMT+2 Borislav Petkov wrote:
> On Fri, May 10, 2024 at 01:21:47PM +0200, Fabio M. De Francesco wrote:
> > Make extlog_print_rcd() log unconditionally to report errors even if
> > userspace is not consuming trace events. Remove ras_userspace_consumers()
> > because it is not anymore used.
> 
> Did you do any git archeology before that?
> 
> d6cae935ec5b ("trace, eMCA: Add a knob to adjust where to save event log")
> 
> I can't find in this commit message why this is needed... Do share pls. 
> 
> > This change makes extlog_print() (ELOG) log consistently with ghes_proc()
> > (GHES).

I thought that ELOG and GHES should be modeled consistently. ghes_proc() 
prints to the console while ghes_do_proc() also uses ftrace. I made this short 
series an RFC mainly to ask / receive comments on this change (3/3).

If we want to make ELOG and GHES act similarly, this patch is needed. 
Otherwise, things should be left the way they currently are. 

I'll make a v3  with a more clear explanation of why I think we should prefer 
to make ELOG act similarly to GHES in how kernel logs are handled.

> Avoid having "This patch" or "This commit" in the commit message. It is
> tautologically useless.
>
> Also, do
> 
> $ git grep 'This patch' Documentation/process
> 
> for more details.
> 
> Pls have a look at our documentation and check all your patches.
> 
> Thx.

Please note that I was introducing the "why" part of the message. I never 
refer to this patch for the "what", and I always use an imperative tone only 
in the "what" part. 

However, I see why this commit message was poor. And probably also the other 
two were low quality. Therefore, I'll rework this and also the other two 
messages.

Thanks for your comments,

Fabio