[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240510125214.GCZj4YfluoP-mDz3_U@fat_crate.local>
Date: Fri, 10 May 2024 14:52:14 +0200
From: Borislav Petkov <bp@...en8.de>
To: "Fabio M. De Francesco" <fabio.m.de.francesco@...ux.intel.com>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>, Len Brown <lenb@...nel.org>,
Tony Luck <tony.luck@...el.com>, linux-acpi@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-edac@...r.kernel.org,
Dan Williams <dan.j.williams@...el.com>
Subject: Re: [RFC PATCH v2 3/3] ACPI: extlog: Make print_extlog_rcd() log
unconditionally
On Fri, May 10, 2024 at 01:21:47PM +0200, Fabio M. De Francesco wrote:
> Make extlog_print_rcd() log unconditionally to report errors even if
> userspace is not consuming trace events. Remove ras_userspace_consumers()
> because it is not anymore used.
Did you do any git archeology before that?
d6cae935ec5b ("trace, eMCA: Add a knob to adjust where to save event log")
I can't find in this commit message why this is needed... Do share pls.
> This change makes extlog_print() (ELOG) log consistently with ghes_proc()
> (GHES).
Avoid having "This patch" or "This commit" in the commit message. It is
tautologically useless.
Also, do
$ git grep 'This patch' Documentation/process
for more details.
Pls have a look at our documentation and check all your patches.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
Powered by blists - more mailing lists