[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20240510104529.26f68fd8@p-imbrenda>
Date: Fri, 10 May 2024 10:45:29 +0200
From: Claudio Imbrenda <imbrenda@...ux.ibm.com>
To: David Hildenbrand <david@...hat.com>
Cc: linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
linux-s390@...r.kernel.org, Heiko Carstens <hca@...ux.ibm.com>,
Vasily
Gorbik <gor@...ux.ibm.com>,
Alexander Gordeev <agordeev@...ux.ibm.com>,
Christian Borntraeger <borntraeger@...ux.ibm.com>,
Sven Schnelle
<svens@...ux.ibm.com>,
Janosch Frank <frankja@...ux.ibm.com>,
Gerald
Schaefer <gerald.schaefer@...ux.ibm.com>,
Matthew Wilcox
<willy@...radead.org>, Thomas Huth <thuth@...hat.com>
Subject: Re: [PATCH v2 10/10] s390/hugetlb: convert PG_arch_1 code to work
on folio->flags
On Wed, 8 May 2024 20:08:07 +0200
David Hildenbrand <david@...hat.com> wrote:
> On 07.05.24 18:33, Claudio Imbrenda wrote:
> > On Fri, 12 Apr 2024 16:21:20 +0200
> > David Hildenbrand <david@...hat.com> wrote:
> >
> >> Let's make it clearer that we are always working on folio flags and
> >> never page flags of tail pages.
> >
> > please be a little more verbose, and explain what you are doing (i.e.
> > converting usages of page flags to folio flags), not just why.
> >
> >>
> >> Signed-off-by: David Hildenbrand <david@...hat.com>
> >
> > with a few extra words in the description:
>
> Let's make it clearer that we are always working on folio flags and
> never page flags of tail pages by converting remaining PG_arch_1 users
> that modify page->flags to modify folio->flags instead.
>
> No functional change intended, because we would always have worked with
> the head page (where page->flags corresponds to folio->flags) and never
> with tail pages.
this works, thanks!
>
>
> >
> > Reviewed-by: Claudio Imbrenda <imbrenda@...ux.ibm.com>
>
> Thanks for all the review!
>
Powered by blists - more mailing lists