linux-kernel - [PATCH] media: i2c: replacing of_node_put with __free(device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240510100324.5961-1-abdulrasaqolawani@gmail.com>
Date: Fri, 10 May 2024 06:03:24 -0400
From: Abdulrasaq Lawani <abdulrasaqolawani@...il.com>
To: sakari.ailus@...ux.intel.com,
	dave.stevenson@...pberrypi.com,
	jacopo@...ndi.org,
	mchehab@...nel.org,
	julia.lawall@...ia.fr
Cc: Abdulrasaq Lawani <abdulrasaqolawani@...il.com>,
	linux-media@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	skhan@...uxfoundation.org,
	javier.carrasco.cruz@...il.com
Subject: [PATCH] media: i2c: replacing of_node_put with __free(device_node)

Replaced instance of of_node_put with __free(device_node)
to protect against any memory leaks due to future changes
in control flow.

Suggested-by: Julia Lawall <julia.lawall@...ia.fr>
Signed-off-by: Abdulrasaq Lawani <abdulrasaqolawani@...il.com>
---
 drivers/media/i2c/ov5647.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/media/i2c/ov5647.c b/drivers/media/i2c/ov5647.c
index 7e1ecdf2485f..d593dba092e3 100644
--- a/drivers/media/i2c/ov5647.c
+++ b/drivers/media/i2c/ov5647.c
@@ -1360,23 +1360,19 @@ static int ov5647_parse_dt(struct ov5647 *sensor, struct device_node *np)
 	struct v4l2_fwnode_endpoint bus_cfg = {
 		.bus_type = V4L2_MBUS_CSI2_DPHY,
 	};
-	struct device_node *ep;
+	struct device_node *ep __free(device_node) = of_graph_get_endpoint_by_regs(np, 0, -1);
 	int ret;
 
-	ep = of_graph_get_endpoint_by_regs(np, 0, -1);
 	if (!ep)
 		return -EINVAL;
 
 	ret = v4l2_fwnode_endpoint_parse(of_fwnode_handle(ep), &bus_cfg);
 	if (ret)
-		goto out;
+		return ret;
 
 	sensor->clock_ncont = bus_cfg.bus.mipi_csi2.flags &
 			      V4L2_MBUS_CSI2_NONCONTINUOUS_CLOCK;
 
-out:
-	of_node_put(ep);
-
 	return ret;
 }
 
-- 
2.34.1