linux-kernel - Re: [PATCH v7] ACPI: fan: Add hwmon support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 10 May 2024 16:30:33 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Armin Wolf <W_Armin@....de>
Cc: mlj@...elec.com, rafael.j.wysocki@...el.com, lenb@...nel.org, 
	jdelvare@...e.com, linux@...ck-us.net, linux@...ssschuh.net, 
	ilpo.jarvinen@...ux.intel.com, linux-acpi@...r.kernel.org, 
	linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org, 
	platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH v7] ACPI: fan: Add hwmon support

On Fri, May 10, 2024 at 1:19 AM Armin Wolf <W_Armin@....de> wrote:
>
> Currently, the driver does only support a custom sysfs
> interface to allow userspace to read the fan speed.
> Add support for the standard hwmon interface so users
> can read the fan speed with standard tools like "sensors".

> Tested with a custom ACPI SSDT.

This most likely fits the comment/changelog area and not the commit
message. Also would be good to put there the link to this custom SSDT
(like one of zillion of pastebin sites, or GitHub, or ...).

I was under the impression that Guenter gave a tag, which is missing,
but no, he just said it's okay to go. Guenter, maybe a formal
Acked-by?

Some cosmetic related remarks below.

..

> +/*
> + * Hwmon interface for the ACPI Fan driver.

I would use hwmon (as it is an abbreviation based compound word which
we know in small letters).

> + *
> + * Copyright (C) 2024 Armin Wolf <W_Armin@....de>
> + */

..

> +#include <linux/acpi.h>
> +#include <linux/device.h>
> +#include <linux/err.h>
> +#include <linux/hwmon.h>
> +#include <linux/limits.h>

+ types.h

> +#include <linux/units.h>

..

The rest LGTM, FWIW,
Reviewed-by: Andy Shevchenko <andy@...nel.org>

-- 
With Best Regards,
Andy Shevchenko